From clsparse<Vector><Scalar>Private to clsparse::vector<T> about clsparse HOT 3 CLOSED

I agree with this general direction. However, I do not think that it can replace ALL of the clsparse private structs, as they contain a lot of host data. For sure, I would hope that they could be used for all cl_mem or void* members.

You may have to create a special constructor, which can 'give' already allocated device memory to the vector. The destructor would also have to be special, because it does not in fact 'own' the memory. In a way, this is kind of like a weak_ptr concept from shared_ptr model. However, when we create temporary internal buffers, we obviously want it to allocated and deallocate the memory because it 'owns' the memory.

from clsparse.

The clsparse::vector and array are already present in the code. In every iteration I see the progress where the clsparse::vector is overtaking the *Private concept.

from clsparse.

Yes, and this is a good thing. If we could eventually eliminate the *Private and the memmapRAII classes, clsparse becomes simpler to maintain. With respect to your question in #138, bolt::device_vector would potentially replace clsparse::vector.

from clsparse.