cider-log: multiline items about cider HOT 5 OPEN

Hi @vemv,
I think this can also happen when stacktraces are printed. I don't have strong opinions and I'm fine with rendering it on a single line. We also truncate long messages to not bring Emacs down, with the idea that you can inspect them if you really want to.

from cider.

@vemv I don't follow, what do you mean by "I've noticed that the newlines may be our fault sometimes".

I meant, maybe somewhere in logjam we use pr-str instead of str for exceptions.

But I was probably wrong in saying that, the pr-str or str is not performed by logjam, but by either the logging library or the user application.

. By default we could show only the single/first line, but if the user presses a key (maybe TAB), the log line would expand and show on multiple lines.

This would sgtm! Assuming it would be reasonably cheap and would not compromise anything.

I believe I changed them to also be printed on multiple lines.

Yes, correct, that would be good reasoning for trimming the lines, guilt-free :)

One last consideration: if we are to remove newlines, we shouldn't just remove the newlines, but also truncate everything after the first newline.

The reason is that long lines are known to cause Emacs slowness.

from cider.

Thanks!

Good idea on truncating. We could have options if anyone wanted to opt out.

I've noticed that the newlnes may be our fault sometimes:

that output can reproduced with a simple (c.t.l/error :foo (ex-info "a" {})).

Maybe we could be using pr-str / str better somewhere in Logjam, idk.

from cider.

@vemv I don't follow, what do you mean by "I've noticed that the newlines may be our fault sometimes".

Another idea that came to my mind is: Maybe it's actually nice to see the printed exception sometimes, or the "thing" that spans multiple lines. By default we could show only the single/first line, but if the user presses a key (maybe TAB), the log line would expand and show on multiple lines. That key can be a toggle, you press it again and it goes back to a single line. This could be useful if you are fishing for something in the logs.

Exceptions are probably better viewed in the stacktrace inspector, but for long strings that could be useful. I think you can also jump into the inspector and view long strings there. I believe I changed them to also be printed on multiple lines.

from cider.

Thanks for the clarification. Yes, truncating according to cider-log-max-message-length seems fine.

from cider.