Giter VIP home page Giter VIP logo

Comments (2)

jqmtor avatar jqmtor commented on July 24, 2024

Is it possible that this function should be slightly different?

It looks like it should ensure the compatibility of the keys that are passed to ->action-requests (see here), but it is only removing the leading underscore. So the :_version_type key is transformed to :version_type instead of :version-type. I tried looking for more insight in the commit messages but it didn't help.

I think it is also fair to argue that clojurewerkz.elastisch.common.bulk should not take care of these keys, since they are different in each client.

@michaelklishin what do you think? I am open to submit a PR with the required changes.

from elastisch.

michaelklishin avatar michaelklishin commented on July 24, 2024

@quimrstorres if you have a test case that demonstrates the issue to go with it, feel free to do it. Af first glance your findings seem reasonable. Thank you.

from elastisch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.