Giter VIP home page Giter VIP logo

Comments (6)

loris avatar loris commented on July 18, 2024

In the meantime, I think it would be great to allow disabling http2 by changing:

  constructor: function (auth) {
    var client = new Client({
      email: auth && auth.email,
      key: auth && auth.key,
      h2: true
    });

to something like this:

  constructor: function (opts) {
    var client = new Client({
      email: opts && opts.email,
      key: opts && opts.key,
      h2: opts && opts.h2 !== undefined ? opts.h2 : true
    });

Then node-cloudclare users could just

var cf = require('cloudflare')({
  email: '[email protected]',
  key: 'your Cloudflare API key',
  h2: false
});

from node-cloudflare.

loris avatar loris commented on July 18, 2024

To add more context, it looks like it always throws that error on my hosting provider: Heroku, but it works on my local machine. Reverting to 1.1.1 for now.

from node-cloudflare.

terinjokes avatar terinjokes commented on July 18, 2024

I may decide to allow disabling HTTP2, but I'd rather prefer not. Can you tell me how you're using this from Heroku so I can investigate?

from node-cloudflare.

terinjokes avatar terinjokes commented on July 18, 2024

@loris With HTTP2 being worked on in core, I've pulled out the support in this module. Let me know if 2.1.1 works for you.

from node-cloudflare.

loris avatar loris commented on July 18, 2024

@terinjokes thanks a lot, sure 2.1.1 works like a charm

from node-cloudflare.

terinjokes avatar terinjokes commented on July 18, 2024

@loris Great. Now I just need to sit down and support the other endpoints :)

from node-cloudflare.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.