Dependencies upgrade about node-cloudflare HOT 17 CLOSED

Any update on this deprecation warning issue...it's literally 2.5 yrs old ? 😂

from node-cloudflare.

Any update on this ? Thanks for doing your best.

from node-cloudflare.

Hi @terinjokes many thanks for your work on this.
Do you have a rough idea of when the deprecated _headers will be replaced?

from node-cloudflare.

@terinjokes you talk about got API leaking through a lot. Can you elaborate please? Why can't this project use the latest version of got?

from node-cloudflare.

Hey,

Upgrades of dependencies are planned, just not finished yet.

from node-cloudflare.

I'm working on a 3.0 that stops using got, until then there's no good way for me to fix this.

from node-cloudflare.

There's no version of the got dependency where this message is fixed that doesn't also break their API. Since the got API leaks through a lot, it's not feasible to upgrade without also having a breaking change ourselves.

from node-cloudflare.

@vkentta this is believed to be fixed in 2.8.0

from node-cloudflare.

Wow... It is still not fixed. Impressive...

from node-cloudflare.

It's gonna be 4th year anniversary for this issue 🎉 😅
tl;dr
For anyone if it helps, if you run with --trace-deprecation option and you get something along the lines timed-out/index.js this is for you

this line is the culprit var host = req._headers ? (' to ' + req._headers.host) : '';
change it to var host = req.getHeaders() ? (' to ' + req.getHeaders().host) : ''; and you should be good to go 😛

from node-cloudflare.

Hi @terinjokes

any update about the upgrade of dependencies ? I am getting the same message.

from node-cloudflare.

What's wrong with making a breaking change? People on old versions of node can just use the older version of the module.
Also, getHeaders() is supported all the way back to version 8.

from node-cloudflare.

@sadtaco It's more difficult both for us developing this package and for users. Especially since the "breaking change" isn't just changing the version number in package.json: newer versions of got are very different.

from node-cloudflare.

As a workaround one can use node v10. Would love to get the fix though 🥰

from node-cloudflare.

Are there any updates on this?
I'd hate delivering my software while these warnings are spammed to the console.

from node-cloudflare.

Any updates? A fix would be nice

from node-cloudflare.

Still getting this warning on node 18. Maybe somebody have made a fork with the fix or could point out how to fix it so I could update it and share the fork myself?

from node-cloudflare.