Giter VIP home page Giter VIP logo

Comments (9)

rohit-gohri avatar rohit-gohri commented on July 19, 2024

I think this is still an issue, the output of the example workflow doesn't return the correct alias - https://github.com/cloudflare/pages-action/actions/runs/3631522134/jobs/6126266418#step:4:11

Haven't tested in my repo yet

from pages-action.

WalshyDev avatar WalshyDev commented on July 19, 2024

I think this is still an issue, the output of the example workflow doesn't return the correct alias - cloudflare/pages-action/actions/runs/3631522134/jobs/6126266418#step:4:11

Haven't tested in my repo yet

That was for production, production doesn't have an alias so it can't return one. What would you expect there?

from pages-action.

rohit-gohri avatar rohit-gohri commented on July 19, 2024

The main url, https://github-actions-example.pages.dev/ ? Since that is the "alias" for production

from pages-action.

peschee avatar peschee commented on July 19, 2024

I am also running into this issue. Given this simple config:

      - name: Publish to Cloudflare Pages
        uses: cloudflare/[email protected]
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: yyy
          projectName: xxx
          directory: zzz
          gitHubToken: ${{ secrets.GITHUB_TOKEN }}
        id: publish

I get this alias in these outputs from the action when running in on a branch (e.g. in a PR)

ID: 8a8296e1-e646-45ca-9bae-9ed8001c7fb9
URL: https://8a8296e1.xxx.pages.dev
Environment: preview
Alias: https://head.xxx.pages.dev

I guess head is wrong here?

from pages-action.

peschee avatar peschee commented on July 19, 2024

Maybe related to #22 ?

from pages-action.

peschee avatar peschee commented on July 19, 2024

When I add the branch parameter, I do not get the head alias, but the alias still seems wrong. The action outputs are:

ID: 2640a0f7-9755-4666-b3c7-046b95704a59
URL: https://2640a0f7.xxx.pages.dev
Environment: preview
Alias: https://2640a0f7.xxx.pages.dev

but the alias Cloudflare Pages assigns would be something like branch-name.xxx.pages.dev when the PR branch is branch-name and my domain is xxx.

Run cloudflare/[email protected]
  with:
    apiToken: ***
    accountId: yyy
    projectName: xxx
    directory: dist
    gitHubToken: ***
    branch: branch-name

from pages-action.

peschee avatar peschee commented on July 19, 2024

Funnily enough, any subsequent push (and deployment) of a PR branch uses the right alias…

EDIT: no it does not. I think we might be running into #29 here, since sometimes it works and sometimes it does not.

from pages-action.

sastan avatar sastan commented on July 19, 2024

I have created a PR (#40) that tries to fix this issue.

from pages-action.

IanVS avatar IanVS commented on July 19, 2024

It seems like this should be re-opened, right? I'm not getting the alias in the output.

from pages-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.