Comments (9)
I think this is still an issue, the output of the example workflow doesn't return the correct alias - https://github.com/cloudflare/pages-action/actions/runs/3631522134/jobs/6126266418#step:4:11
Haven't tested in my repo yet
from pages-action.
I think this is still an issue, the output of the example workflow doesn't return the correct alias - cloudflare/pages-action/actions/runs/3631522134/jobs/6126266418#step:4:11
Haven't tested in my repo yet
That was for production, production doesn't have an alias so it can't return one. What would you expect there?
from pages-action.
The main url, https://github-actions-example.pages.dev/ ? Since that is the "alias" for production
from pages-action.
I am also running into this issue. Given this simple config:
- name: Publish to Cloudflare Pages
uses: cloudflare/[email protected]
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
accountId: yyy
projectName: xxx
directory: zzz
gitHubToken: ${{ secrets.GITHUB_TOKEN }}
id: publish
I get this alias in these outputs from the action when running in on a branch (e.g. in a PR)
ID: 8a8296e1-e646-45ca-9bae-9ed8001c7fb9
URL: https://8a8296e1.xxx.pages.dev
Environment: preview
Alias: https://head.xxx.pages.dev
I guess head
is wrong here?
from pages-action.
Maybe related to #22 ?
from pages-action.
When I add the branch
parameter, I do not get the head
alias, but the alias still seems wrong. The action outputs are:
ID: 2640a0f7-9755-4666-b3c7-046b95704a59
URL: https://2640a0f7.xxx.pages.dev
Environment: preview
Alias: https://2640a0f7.xxx.pages.dev
but the alias Cloudflare Pages assigns would be something like branch-name.xxx.pages.dev
when the PR branch is branch-name
and my domain is xxx
.
Run cloudflare/[email protected]
with:
apiToken: ***
accountId: yyy
projectName: xxx
directory: dist
gitHubToken: ***
branch: branch-name
from pages-action.
Funnily enough, any subsequent push (and deployment) of a PR branch uses the right alias…
EDIT: no it does not. I think we might be running into #29 here, since sometimes it works and sometimes it does not.
from pages-action.
I have created a PR (#40) that tries to fix this issue.
from pages-action.
It seems like this should be re-opened, right? I'm not getting the alias in the output.
from pages-action.
Related Issues (20)
- Document permissions required for Github Access Token HOT 1
- how can I set a service binding via this action? HOT 1
- Post-upload fails HOT 3
- Unable to publish site, API return 503 and 504 errors HOT 1
- Disable Wrangler
- Specifying `--compatibility-flags` HOT 2
- Action fails after Deployment complete! HOT 2
- GitHub Actions failing on run
- Deploying with cloudflare/pages-action but cannot locate sveltekit build directory HOT 2
- Update README GITHUB_TOKEN to DEPLOY_TOKEN HOT 1
- Authentication Error 10000 on endpoint /upload-token HOT 1
- Trunk based development and differentiating preview vs production env
- Project not found. The specified project name does not match any of your existing projects. HOT 1
- Transitioning from Node 16 to Node 20 HOT 26
- Impossible to set branch deployment options with this action? HOT 1
- Incorrect alias HOT 2
- "No deployment available" when deploying with this action HOT 1
- Failed runs-on windows-latest with node 18/20. But node 16 works fine.
- Using CF_PAGES_URL
- The branch parameter is not defaulted to the branch that triggers a workflow HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pages-action.