Comments (6)
Thanks a ton for the diagram! This makes sense. I'll play around with this and see if I can provide some examples that work for me.
I appreciate your attention to detail @limakzi!
from pages-action.
@andrewgbell I really appreciate this request. ❤️
@jaydrogers Cloudflare Pages and Github Environment are two completely isolated things.
Said that, I would see a proper workflow like this:
flowchart LR
A[Pull-request has been opened] --> B[Environment has been provisioned]
B -->|Provision| Environment
subgraph Environment
C[Github Environment] -. matches .- D[Cloudflare Deployment]
end
E[Pull-request has been merged] --> F[Environment has been decommissioned]
F -->|Decommission| Environment
from pages-action.
FWIW I found this action that does have the option to delete when a PR is closed: https://github.com/unlike-ltd/github-actions-cloudflare-pages
from pages-action.
I am wondering if there will be support for this as well.
I wonder if there is a workaround that we can run via the API to delete it? Seems "hacky" to do, but it would be nice to get official word if this is planned to be supported or not before messing with the API. 🙌
Source
https://community.cloudflare.com/t/delete-cloudlfare-pages-deployments/345640
from pages-action.
Looking into this further, I noticed when I deleted the environment from GitHub it automatically deleted it from the CloudFlare dashboard too.
I wonder if managing this through the GitHub API might be a better approach?
from pages-action.
The action @rmoff linked seems to use a basic api fetch: https://github.com/unlike-ltd/github-actions-cloudflare-pages/blob/main/src/cloudflare/deployment/delete.ts#L7
The pages-action
also uses some fetch
es already, so it might be possible to adapt:
Line 52 in aeb0d93
from pages-action.
Related Issues (20)
- Document permissions required for Github Access Token HOT 1
- how can I set a service binding via this action? HOT 1
- Post-upload fails HOT 3
- Unable to publish site, API return 503 and 504 errors HOT 1
- Disable Wrangler
- Specifying `--compatibility-flags` HOT 2
- Action fails after Deployment complete! HOT 2
- GitHub Actions failing on run
- Deploying with cloudflare/pages-action but cannot locate sveltekit build directory HOT 2
- Update README GITHUB_TOKEN to DEPLOY_TOKEN HOT 1
- Authentication Error 10000 on endpoint /upload-token HOT 1
- Trunk based development and differentiating preview vs production env
- Project not found. The specified project name does not match any of your existing projects. HOT 1
- Transitioning from Node 16 to Node 20 HOT 26
- Impossible to set branch deployment options with this action? HOT 1
- Incorrect alias HOT 3
- "No deployment available" when deploying with this action HOT 1
- Failed runs-on windows-latest with node 18/20. But node 16 works fine.
- Using CF_PAGES_URL HOT 2
- The branch parameter is not defaulted to the branch that triggers a workflow HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pages-action.