Ability to delete preview site when pr is closed about pages-action HOT 6 CLOSED

Thanks a ton for the diagram! This makes sense. I'll play around with this and see if I can provide some examples that work for me.

I appreciate your attention to detail @limakzi!

from pages-action.

@andrewgbell I really appreciate this request. ❤️
@jaydrogers Cloudflare Pages and Github Environment are two completely isolated things.
Said that, I would see a proper workflow like this:

flowchart LR
    A[Pull-request has been opened] --> B[Environment has been provisioned]
    B -->|Provision| Environment
	subgraph Environment
	C[Github Environment] -. matches .- D[Cloudflare Deployment]
	end

    E[Pull-request has been merged] --> F[Environment has been decommissioned]
    F -->|Decommission| Environment

from pages-action.

FWIW I found this action that does have the option to delete when a PR is closed: https://github.com/unlike-ltd/github-actions-cloudflare-pages

from pages-action.

I am wondering if there will be support for this as well.

I wonder if there is a workaround that we can run via the API to delete it? Seems "hacky" to do, but it would be nice to get official word if this is planned to be supported or not before messing with the API. 🙌

Source

https://community.cloudflare.com/t/delete-cloudlfare-pages-deployments/345640

from pages-action.

Looking into this further, I noticed when I deleted the environment from GitHub it automatically deleted it from the CloudFlare dashboard too.

I wonder if managing this through the GitHub API might be a better approach?

https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#deleting-an-environment

from pages-action.

The action @rmoff linked seems to use a basic api fetch: https://github.com/unlike-ltd/github-actions-cloudflare-pages/blob/main/src/cloudflare/deployment/delete.ts#L7

The pages-action also uses some fetches already, so it might be possible to adapt:

from pages-action.