Giter VIP home page Giter VIP logo

Comments (5)

WalshyDev avatar WalshyDev commented on August 19, 2024 1

This is already provided in the alias output.

from pages-action.

WalshyDev avatar WalshyDev commented on August 19, 2024 1

We'll fix the issue at some point but it isn't a high priority so it'll be fixed when someone has some free time and wants to fix it.

from pages-action.

jasonkuhrt avatar jasonkuhrt commented on August 19, 2024

Hm, it does not behave how I expected. Is this a bug or expected? How can the GH action output a URL as does the CF GH App? That's what this issue was about.

CleanShot 2023-03-20 at 17 14 32@2x

from pages-action.

WalshyDev avatar WalshyDev commented on August 19, 2024

There's a case where it doesn't have the actual alias like half the time. That's an issue with the Pages API however not this action.

(reason for this is wrangler will exit before the edge deployment however we only update the pointed alias after the edge deploy. So, if the edge deploy hasn't been completed by the time we do our API request, the alias hasn't been updated.)

from pages-action.

jasonkuhrt avatar jasonkuhrt commented on August 19, 2024

@WalshyDev interesting, is this expected to improve or not really? At least now I have a good link to put in our code comment, thanks!

from pages-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.