Giter VIP home page Giter VIP logo

Comments (5)

WalshyDev avatar WalshyDev commented on August 19, 2024 6

Yeah I intend to cut a v2 at some point soon which defaults wrangler to v3 and uses the correct command.
Deprecation is expected and fine for now. This command won't be removed until at least wrangler v4.

from pages-action.

smvz avatar smvz commented on August 19, 2024 2

I don't know whether or not the pull request #101 works as-is (I see that code is in two places and it only changes one) but a change of that nature would deal with the deprecation warning in a way that is non-breaking, so people using the v1 action with wrangler v3 aren't confused by it.

from pages-action.

rodbs avatar rodbs commented on August 19, 2024

I guess they need to update the action script according to the new wrangler parameters:
https://developers.cloudflare.com/workers/wrangler/commands/#publish-1

from pages-action.

rodrigoalcarazdelaosa avatar rodrigoalcarazdelaosa commented on August 19, 2024

I see that code is in two places and it only changes one

I only see it here. Where else is the pages publish referenced?

from pages-action.

smvz avatar smvz commented on August 19, 2024

I believe I was referring to here. I see now though that the .husky directory contains a pre-commit script to build index.js from src/index.ts, so it is just the one place.

from pages-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.