Comments (5)
Yeah I intend to cut a v2 at some point soon which defaults wrangler to v3 and uses the correct command.
Deprecation is expected and fine for now. This command won't be removed until at least wrangler v4.
from pages-action.
I don't know whether or not the pull request #101 works as-is (I see that code is in two places and it only changes one) but a change of that nature would deal with the deprecation warning in a way that is non-breaking, so people using the v1 action with wrangler v3 aren't confused by it.
from pages-action.
I guess they need to update the action script according to the new wrangler parameters:
https://developers.cloudflare.com/workers/wrangler/commands/#publish-1
from pages-action.
I see that code is in two places and it only changes one
I only see it here. Where else is the pages publish
referenced?
from pages-action.
I believe I was referring to here. I see now though that the .husky
directory contains a pre-commit script to build index.js
from src/index.ts
, so it is just the one place.
from pages-action.
Related Issues (20)
- Document permissions required for Github Access Token HOT 1
- how can I set a service binding via this action? HOT 1
- Post-upload fails HOT 3
- Unable to publish site, API return 503 and 504 errors HOT 1
- Disable Wrangler
- Specifying `--compatibility-flags` HOT 2
- Action fails after Deployment complete! HOT 2
- GitHub Actions failing on run
- Deploying with cloudflare/pages-action but cannot locate sveltekit build directory HOT 2
- Update README GITHUB_TOKEN to DEPLOY_TOKEN HOT 1
- Authentication Error 10000 on endpoint /upload-token HOT 1
- Trunk based development and differentiating preview vs production env
- Project not found. The specified project name does not match any of your existing projects. HOT 1
- Transitioning from Node 16 to Node 20 HOT 26
- Impossible to set branch deployment options with this action? HOT 1
- Incorrect alias HOT 3
- "No deployment available" when deploying with this action HOT 1
- Failed runs-on windows-latest with node 18/20. But node 16 works fine.
- Using CF_PAGES_URL HOT 2
- The branch parameter is not defaulted to the branch that triggers a workflow HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pages-action.