Comments (3)
Sounds like a good plan to move away from using inline-relations-depth=2
(currently in use by apps.go
and secgroups.go
). Whoever implements this will want to consider an appropriate parallelism method to make the depth calls to find child objects. Or, we make a breaking change and only return depth=1?
from go-cfclient.
The inline-relations-depth=2
on apps can also cause significant memory usage if the apps belong to spaces that have a large number of relationships themselves.
How bad would a breaking change here actually be given that the project isn't versioned and the README mentions this?
NOTE: Currently this project is not versioning its releases and so breaking changes might be introduced. Whilst hopefully notifications of breaking changes are made via commit messages, ideally your project will use a local vendoring system to lock in a version of go-cfclient that is known to work for you. This will allow you to control the timing and maintenance of upgrades to newer versions of this library.
If I were a consumer I'd be a bit surprised that calling ListApps
pulls so much data personally.
from go-cfclient.
inline-relations-depth
is deprecated in v2 but generally still works. Generally we should be moving towards v3 endpoints and leave v2 behavior as-is to avoid breaking consumers.
from go-cfclient.
Related Issues (20)
- Update security group cannot remove all rules HOT 4
- [Request/Discussion] Moving the client to he CloudFoundry Foundation Org HOT 3
- ServiceInstance create has only parameters for managed offering. Missing params for user provided service instance creation HOT 2
- Make health-check-http-endpoint optional HOT 5
- Port attribute in route should be nullable
- Support for manifest generation api
- Invalid attributes in Domain Create
- Manifest unmarshal fails with service type HOT 7
- Delete Service Credential Binding does not return job GUID
- Create role via username and origin HOT 1
- Unable to update-unset route_service_url/tags from service instance
- Name attribute in service credential binding should be nullable
- Extra attributes appearing in credential binding details
- Unable to set instances to 0 in app manifest
- Delete Buildpack does not return job GUID
- Unable to update-unset stack for buildpack
- Filename is hardcoded while uploading buildpack
- Stack attribute in buildpack should be nullable
- Missing fields in stack resource HOT 2
- Go build fails due to Golang cross compile undefined errors with C module HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-cfclient.