About New Relic, we can not disable installing it. about nodejs-buildpack HOT 8 CLOSED

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/130344397

The labels on this github issue will be updated when the story is started.

from nodejs-buildpack.

@patapata23 can you please explain what it is you're trying to do?

Staging will always have VCAP_APPLICATION set as an environment variable (even if it's just an empty hash), so if VCAP_APPLICATION is missing, your environment is not truly emulating staging.

from nodejs-buildpack.

To add to that, a number of other buildpacks expect VCAP_APPLICATION to be set as well.

Here's a Dockerfile that fully simulates staging and launching: https://github.com/sclevine/cflocal/blob/master/Dockerfile

from nodejs-buildpack.

@RochesterinNYC Thank you for your reply.
I'll trying to excute only unit-test in nodejs-buildpack environment.
when my envrironment is truly emulating staging envirionment, It will be executed in the order of the detect -> compile -> release .
I'll executing the only compile command in our concourse CI for unit-testing.

Certainly, This Issue is solved by setting the environment variable as you're right.
I want to know why you require New Relic library.

from nodejs-buildpack.

What do you mean by execute only unit-test? Do you mean you're only trying to execute the unit tests in the nodejs buildpack? i.e. https://github.com/cloudfoundry/nodejs-buildpack/tree/master/cf_spec/unit ?

What exactly are you unit testing?

I'm not sure you what you mean by requiring the New Relic library.

from nodejs-buildpack.

@RochesterinNYC

What exactly are you unit testing?

I use this buildpack in Concourse CI, not in CloudFondry environment.
So, there is no VCAP_APPLICATION.

I compile my own app with nodejs-buildpack, then I execute unit-tests in my app.

I'm not sure you what you mean by requiring the New Relic library.

when excuting compile, New Relic is always installed.
I do not know why New Relic is always installed.
Because did not install the New Relic, heroku.
https://github.com/heroku/heroku-buildpack-nodejs/blob/master/bin/compile

from nodejs-buildpack.

You're using the nodejs buildpack to stage apps on Concourse? If that's the case, I wouldn't refer to these Cloud Foundry buildpacks as generic enough that they can stage any app on any environment. They're attuned to Cloud Foundry and they are Cloud Foundry buildpacks, so you'd need to either fork the buildpack and remove Cloud Foundry specific nuances or alter your staging environment to emulate the Cloud Foundry staging environment.

The NewRelic library is not included as part of the nodejs-buildpack at all. The NewRelic client library is contained in a newrelic.js file that users include in their applications. We only have support in the buildpack to set some New Relic environment variables if your app binds to a New Relic service broker. I'm not sure what you're referring to.

from nodejs-buildpack.

@RochesterinNYC
Your explanation was understanding. And polite reply thanks.
I'll try to test by setting the staging environment in concourseCI.

About NewRelic library, it had been the understanding that I was wrong. I'm sorry.

Thank you very much.

from nodejs-buildpack.