Giter VIP home page Giter VIP logo

Comments (3)

clwainwright avatar clwainwright commented on August 15, 2024

Hi Mike,

It's been a while since I've looked at this, but the intention was definitely to find the correct higher temperature in situations like this. The critical section of code is in transitionFinder.tunnelFromPhase(), in particular line 843. If it runs into a situation where S3/T is bigger than 140 at both Tmax and Tmin, it should attempt to find a new Tmin somewhere in between where S3/T is in fact at its minimum. It will then use that new minimum as the baseline for finding the point at which S3/T first drops below 140. I'm not sure why it would be returning the lower of the two temperatures instead.

If you provide a reproducible test case I should be able to dig into it some more.

Best wishes,
Max

from cosmotransitions.

PhysicsBaker avatar PhysicsBaker commented on August 15, 2024

Hi Max,

Thanks again for your swift reply. The problem seems to be with the new Tmax that's found by transitionFinder._maxTCritForPhase(), if f(a) and f(b) have the same sign. In my case, Tmax is getting set to 0. I think I've tracked down the cause of the problem to the function transitionFinder._potentialDiffForPhase().

Line 722 is currently

    V1 = V(start_phase.valAt(T),T)

whereas I think it should be

    V1 = V(phase.valAt(T),T)

Do you agree?

If I make this change, cosmoTransitions finds the correct, higher, nucleation temperature in my case.

Best,

Michael

from cosmotransitions.

clwainwright avatar clwainwright commented on August 15, 2024

That definitely looks like a bug. Thanks for catching it. I've pushed a commit with the offending line swapped out.

from cosmotransitions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.