Giter VIP home page Giter VIP logo

Comments (5)

ndmitchell avatar ndmitchell commented on May 24, 2024 2

Sorry for taking so long to get back to you. I reinstalled everything with a newer toolchain, and recompiled cargo-instruments and it worked this time - so I assume a newer Cargo dependency or similar fixed it?

In general, for better support for workspaces, allowing the user to be in the root and run --bin=whatever_binary rather than changing directory to the inner Cargo.toml would be super useful.

from cargo-instruments.

BratSinot avatar BratSinot commented on May 24, 2024 1

Sorry for taking so long to get back to you. I reinstalled everything with a newer toolchain, and recompiled cargo-instruments and it worked this time - so I assume a newer Cargo dependency or similar fixed it?

Greetings!

Could you please give some additional info about how you solved this? I'm facing the same problem now.
Ok, my problem was edition = 2021: #53

from cargo-instruments.

cmyr avatar cmyr commented on May 24, 2024

cargo check also fails to parse this manifest.

More specifically, my manifest is:

[package]
name = "test-instruments-parse-issue"
version = "0.1.0"
authors = ["Colin Rofls <[email protected]>"]
edition = "2018"

cargo-features = ['named-profiles']

[workspace]
members = [
    "inner",
]

and my package structure is,

test-instruments-parse-issue
├── Cargo.toml
└── inner
    ├── Cargo.toml
    └── src
        └── main.rs

2 directories, 3 files

I would like to handle workspaces better, but I need more information in this particular case.

from cargo-instruments.

cmyr avatar cmyr commented on May 24, 2024

I agree that would be a nice improvement.

from cargo-instruments.

tizee avatar tizee commented on May 24, 2024

Here is my demonstration.

.
├── Cargo.lock
├── Cargo.toml
├── bar
│   ├── Cargo.toml
│   ├── benches
│   │   └── my_bench.rs
│   └── src
│       └── main.rs
├── foo
│   ├── Cargo.toml
│   ├── benches
│   │   └── my_bench.rs
│   └── src
│       └── main.rs
├── rust-toolchain.toml
└── src
    └── main.rs

7 directories, 10 files

The manifest is like:

[package]
name = "cargo-instruments-workspace-issue"
version = "0.1.0"
edition = "2021"
# cargo-features = ['named-profiles']

[workspace]
members = ["foo", "bar"]

Only comment out cargo-features = ['named-profiles'] can cargo check work.

It could also applies to manifest with only [workspace] block like this:

[workspace]
members = ["foo", "bar"]

from cargo-instruments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.