Comments (2)
silvin-lubecki
commented on August 22, 2024
Hello @radu-matei sorry I missed this one 😅
In the docker/cli there's a FakeClibut put on purpose in theinternal` package because we don't think it's at the right level for tests.
We instead prefer faking the docker client, like here. Unfortunately the client is a giant interface 😞, but using this pattern I guess you only have to implement the methods you are using? Or maybe we should abstract from the docker client/cli and have our own interface in the cnab-go?
from cnab-go.
radu-matei
commented on August 22, 2024
We do have the integration tests now, which directly create a container.
That being said, executing that test does require a Docker daemon, and it would be nice if we had a fake client.
from cnab-go.
Related Issues (20)
- Use concurrency in the data persistence layer? HOT 1
- Return partial data on error?
- Safe way to generate ULID without possible error?
- Consolidate regex for Claim Name Validation Regex
- Handle context cancellation in the kubernetes driver HOT 1
- Remove custom yaml marshaling from Source struct
- Add Parameter Set HOT 3
- Support streaming outputs
- Use go:embed from Go 1.16 HOT 1
- Require only one review for pull requests to the cnab-go library HOT 9
- Remove @glyn from CODEOWNERS HOT 2
- Can we replace the filesystem store with something queryable like sqlite? HOT 1
- Optional parameters are not injected properly HOT 1
- Unused docker driver config options HOT 1
- Cannot validate a parameter whose default is {} HOT 1
- Don't log a warning about log streaming before the container has started
- Remove CRUD data access layer
- Flake: TestClaimSchema HOT 2
- Flake: TestDockerDriver_Run
- Make owner reference configurable for resources created by the kubernetes driver
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cnab-go.