Comments (4)
My take is easy : unless the bundle author marks a cred ad "optional", duffle should fail nicely. The bundle author is in control here.
Do I misunderstand?
from cnab-go.
The spec says that unless you say it is required, it is optional. Since duffle is the reference implementation of the spec, that is the way itโs implemented. Either way, we produce an error when any credential is declared and not provided. That seems unexpected to me.
Optional? You must provide it.
Requires? You must provide it.
I donโt like that.
from cnab-go.
If it's optional by the spec, we should not fail if it is not provided. If the bundle requires it, then we must fail. Does that sound right?
from cnab-go.
This is actually a problem in cnab-go
, will move the issue over there.
from cnab-go.
Related Issues (20)
- Use concurrency in the data persistence layer? HOT 1
- Return partial data on error?
- Safe way to generate ULID without possible error?
- Consolidate regex for Claim Name Validation Regex
- Handle context cancellation in the kubernetes driver HOT 1
- Remove custom yaml marshaling from Source struct
- Add Parameter Set HOT 3
- Support streaming outputs
- Use go:embed from Go 1.16 HOT 1
- Require only one review for pull requests to the cnab-go library HOT 9
- Remove @glyn from CODEOWNERS HOT 2
- Can we replace the filesystem store with something queryable like sqlite? HOT 1
- Optional parameters are not injected properly HOT 1
- Unused docker driver config options HOT 1
- Cannot validate a parameter whose default is {} HOT 1
- Don't log a warning about log streaming before the container has started
- Remove CRUD data access layer
- Flake: TestClaimSchema HOT 2
- Flake: TestDockerDriver_Run
- Make owner reference configurable for resources created by the kubernetes driver
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cnab-go.