Comments (2)
From ChatGPT:
The error message Cannot perform an interactive login from a non TTY device is occurring because the docker login command is trying to run in a non-interactive shell, and it's failing due to the absence of the required environment variables that should be populated with secrets.
The solution would be to somehow implement the pull_request_target
event. But there are possible problems with security, some described in this stackoverflow thread.
from testsuite.
Some analysis about secret usage in our workflows:
We have only 2 places in our actions where secrets are needed:
- GITHUB_TOKEN
- Docker login ENV
IMO GitHub token usage can be safely removed from actions as it is used for automatic creation of releases for each PR (which is redundant from my sight, we have 587 releases at the moment).
Docker login is a harder situation to solve, as i remember - we need it because of the large amounts of pulled images during testing.
I see two solutions there:
- Check and fix if possible that large amount of requests to DockerHub in our spec tests
- Pre-load all the required images to the runners before the start of the test (but it could lead to the same limitations)
About pull_request_target: Seems that it can help by running in "privileged mode" on the target branch for PR, but checking out code from the "change" branch of PR. Security measures need to be taken not to leak secrets through environment or other means. Also, it seems that we wouldn't be able to test changes to CI with this method (as it will always run CI from main), some additional tricks would be needed.
I could be missing or misunderstanding something, feel free to correct.
from testsuite.
Related Issues (20)
- [MAINTENANCE] Remove AIRGAP mode from code HOT 1
- [Feature] Separate manifest installation mode from helm
- [Feature] Join installation modes HelmChart and HelmDirectory
- [Feature] Redesign oran_e2_connection test HOT 1
- [Feature] redesign observability tracing test
- [Feature] Redesign workload_resource_test function HOT 2
- [MAINTENANCE] Remove and exchange duplicate test for privileged containers
- [MAINTENANCE] update stable/envoy HOT 3
- [MAINTENANCE] Align cert set with "Certification 2.0 beta" - reduce it to 19 essential tests
- Test Documentation Updates
- [EPIC] Redesign CNF installation process
- [Feature] CNF installation (1), Implement new config format
- [MAINTENANCE] Delete or redesign of CNF configuration HOT 1
- [Feature] Redesign manifest generation for helm charts
- [Feature] CNF installation (4), Create and use common manifest
- [Feature] CNF Installation (2), Config format transformer for older version
- [Feature] Should we remove "ip_addresses" test?
- [Feature] Install cnfs into system-wide directory
- [Feature] CNF Installation (3), Switch to new config usage
- [BUG] Image size spec test using protected repo is not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testsuite.