Comments (3)
@hemangsk , why add --dir
instead of setting the desired directory as the actual working directory?
I am worried that adding this feature in quickstart, without first implementing the feature in coala-ci
, will unearth a few hidden bugs in coala , where assumptions about the current directory relative to the config and the OS current working directory.
Also, as a general thought --dir
is too generic an argument name, as coala
already has --bears-dir
which is aliased to -d
.
from coala-quickstart.
Understood, we'd need to plan this feature in coala -ci first, and then move the design towards quickstart.
Yea, I can see this being a useful feature for coala generally, but the tests will be much more useful, as it will provide a very useful way to verify that the current directory handling is working properly.
c.f. coala/coala#3867 for an example of one of the problems in this area that is concerning me.
I am glad to hear that you've found a workaround for this problem.
Lets create a task over in the coala repo...
from coala-quickstart.
@jayvdb actually earlier I was thinking that this option would be good as an enhancement to quickstart.
assumptions about the current directory relative to the config and the OS current working directory
Understood, we'd need to plan this feature in coala -ci first, and then move the design towards quickstart.
Setting the desired directory as the actual working directory
I found the cwd
option available for subprocess, to change working directory.
For this particular use case where I have to run coala-quickstart, inside web services, doing
cmd = "coala-quickstart --ci --allow-partial-sections"
shell_output, shell_err = run_shell_command(cmd, cwd=directory_name)
is entirely solving the purpose 🎉 . Thanks a lot!
from coala-quickstart.
Related Issues (20)
- Node initialiser includes dead code HOT 1
- initialize_project_data includes dead code HOT 1
- function green_mode unnecessary delayed import of check_filename_prefix_postfix HOT 10
- UtilitiesTest.py test method test_search_for_orig contains dead code HOT 2
- test_bear_test_fun_2 contains unused test_unified_results HOT 2
- TestUtilities.py bear_test_module unused variable mocked HOT 1
- .travis.yml: Cache ntlk data
- add .coafile.green to .gitignore HOT 1
- facilitate deletion of coafile.green on running pytest HOT 3
- Investigate: how to use the nextgen-core for more reliable and easier processing of bears HOT 1
- coala-ci failing because of old version of a bear
- green_modeTest.py: Unused import AllKindsOfSettingsDependentBear HOT 3
- Unable to install for Python 3.7 HOT 2
- Use coala & coala-bears master HOT 2
- Spelling mistake taraget HOT 5
- Spelling mistake caputred HOT 1
- Add .editorconfig to moban sync HOT 1
- green_mode.py: Incomplete branch coverage on python3.6 HOT 2
- Make coala-quickstart generate configuration files in TOML
- spelling of command is incorrect in Installation section. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coala-quickstart.