Giter VIP home page Giter VIP logo

Comments (3)

jayvdb avatar jayvdb commented on August 28, 2024 1

@hemangsk , why add --dir instead of setting the desired directory as the actual working directory?

I am worried that adding this feature in quickstart, without first implementing the feature in coala-ci, will unearth a few hidden bugs in coala , where assumptions about the current directory relative to the config and the OS current working directory.

Also, as a general thought --dir is too generic an argument name, as coala already has --bears-dir which is aliased to -d.

from coala-quickstart.

jayvdb avatar jayvdb commented on August 28, 2024 1

Understood, we'd need to plan this feature in coala -ci first, and then move the design towards quickstart.

Yea, I can see this being a useful feature for coala generally, but the tests will be much more useful, as it will provide a very useful way to verify that the current directory handling is working properly.
c.f. coala/coala#3867 for an example of one of the problems in this area that is concerning me.
I am glad to hear that you've found a workaround for this problem.

Lets create a task over in the coala repo...

from coala-quickstart.

hemangsk avatar hemangsk commented on August 28, 2024

@jayvdb actually earlier I was thinking that this option would be good as an enhancement to quickstart.

assumptions about the current directory relative to the config and the OS current working directory

Understood, we'd need to plan this feature in coala -ci first, and then move the design towards quickstart.

Setting the desired directory as the actual working directory

I found the cwd option available for subprocess, to change working directory.

For this particular use case where I have to run coala-quickstart, inside web services, doing

cmd = "coala-quickstart --ci --allow-partial-sections"

shell_output, shell_err = run_shell_command(cmd, cwd=directory_name)

is entirely solving the purpose 🎉 . Thanks a lot!

from coala-quickstart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.