Giter VIP home page Giter VIP logo

Comments (4)

johannhof avatar johannhof commented on May 26, 2024

Hey, thanks for helping out!

Mmh, that doesn't look like it comes from returning an Array. You can only get that error from lexer::tokenize, which is called in parse. I'll try check out your patch and play around with it. My first guess is that the fixture string at the bottom is lexed incorrectly.

from liquid-rust.

bacoboy avatar bacoboy commented on May 26, 2024

Yea, I wasn't sure what that stacktrace was telling me, but figured the code should give you a good lead.

I assumed it was in lexer too based on the error message (not matching SINGLE_STRING_LITERAL or DOUBLE_STRING_LITERAL -- fails with same message on the quote if you try both ways).

Let me know what you find out!

from liquid-rust.

johannhof avatar johannhof commented on May 26, 2024

So, this seems to be a problem with the assign tag that does not allow for piping and accepts only single values or variables as rhs elements. I should get around fixing that soon. However, I would recommend just leaving that particular test case out for now (the one in tests/filters.rs). There's nothing wrong with your solution and the array should work fine :)

Thanks! Looking forward to your PR!

from liquid-rust.

bacoboy avatar bacoboy commented on May 26, 2024

Thanks for the fix. This fixes splits on non-comma, etc which I think is being tracked in #41. So I'll make a PR with a simple test which passes, but will need to recheck when the comma fix is in.

from liquid-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.