Comments (4)
Hey, thanks for helping out!
Mmh, that doesn't look like it comes from returning an Array. You can only get that error from lexer::tokenize, which is called in parse
. I'll try check out your patch and play around with it. My first guess is that the fixture string at the bottom is lexed incorrectly.
from liquid-rust.
Yea, I wasn't sure what that stacktrace was telling me, but figured the code should give you a good lead.
I assumed it was in lexer too based on the error message (not matching SINGLE_STRING_LITERAL
or DOUBLE_STRING_LITERAL
-- fails with same message on the quote if you try both ways).
Let me know what you find out!
from liquid-rust.
So, this seems to be a problem with the assign
tag that does not allow for piping and accepts only single values or variables as rhs elements. I should get around fixing that soon. However, I would recommend just leaving that particular test case out for now (the one in tests/filters.rs
). There's nothing wrong with your solution and the array should work fine :)
Thanks! Looking forward to your PR!
from liquid-rust.
Thanks for the fix. This fixes splits on non-comma, etc which I think is being tracked in #41. So I'll make a PR with a simple test which passes, but will need to recheck when the comma fix is in.
from liquid-rust.
Related Issues (20)
- How to use the "Template" class. HOT 33
- Allow accessing renderer state/runtime before rendering HOT 6
- with_time unimplemented HOT 3
- Change `master` branch to `main` HOT 3
- could not compile kstring HOT 1
- Render Tag HOT 3
- EmptyDrop and Object indexing HOT 7
- Make struct InnerError public HOT 1
- Open to the idea of supporting less strict parsing/rendering as an option? HOT 3
- Can't render dates with millisecond precision HOT 1
- No way to return a reference for the values method of trait ObjectView
- Dependency Dashboard
- Question: supporting object literals with unknown keys on custom filters HOT 8
- Thoughts on implementing `From<serde_json::Value> for liquid_core::Value`? HOT 2
- How do you use `{% include x.liquid %}`? HOT 2
- Liquid Tag and Echo Tag
- How would you go about implementing a Drop HOT 3
- Add support for u64 numbers?
- Inline comments are not supported HOT 1
- Hash access to globals produces parse error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liquid-rust.