Parser ignores value of BlockReflection::end_tag() about liquid-rust HOT 7 CLOSED

Are diverging start/end tags supported in ruby liquid? Is there precedence in it for it?

from liquid-rust.

Looking through the Liquid documentation, I cannot see any mechanism for registering a block not in the <name>-end<name> format. Blocks are registered with Liquid::Template.register_tag("<name>", <tag-class>) just like non-block tags. Perhaps it would make more sense to remove BlockReflection::end_tag() from the API?

My use-case for block tags not in the <name>-end<name> format are macro definition tags that can be either single-line (in which case the macro is defined as a filter-chain) or a block (in which case the macro is defined as the contents of the block). My original set of macro-definition tags had a tag called define that would define a single-line macro and ones called begindef and enddef for defining a block macro. I chose these names because it made it clear which tags were single-line and which were multi-line.

from liquid-rust.

The overall intention for end_tag was to open us up to simplifying the code like your PR did, we just never got around to doing it. Looking over it, I'm tempted to merge #453. My concern is whether we should enforce end<something> (and how) or not.

from liquid-rust.

One option is to have diverging start/end tags enabled by a feature flag. If the feature flag is enabled, then diverging start/end tags are supported like in #453. If the feature flag is disabled, then attempting to register a block plugin with diverging start/end tags causes a panic.

Otherwise, to me, it seems the clearest way to enforce end<something> block end tags is to just remove the end_tag method.

from liquid-rust.

Been thinking over this and looking over the Ruby code. Technically, someone can override the block_delimiter. There is no place they explicitly say how blocks end.

Think I'll go forward with this.

from liquid-rust.

As far as I could tell, there was no breaking change with this (since using anything else for these fields would have been broken).

I've released liquid-core with this change since I'm assuming thats all that is needed for this.

from liquid-rust.

Sounds good. Thank you.

from liquid-rust.