Giter VIP home page Giter VIP logo

Comments (12)

sgallagher avatar sgallagher commented on July 21, 2024 1

I just pushed out this change. It may take up to a day to propagate.

from cockpit-project.github.io.

garrett avatar garrett commented on July 21, 2024

It looks like we're using A, which requires DNS modification:
https://help.github.com/articles/setting-up-an-apex-domain/#configuring-a-records-with-your-dns-provider

TODO:

  • update DNS with the new IPs (HTTPS should automatically work)
  • remove & re-add domain to trigger new cert
  • "Enforce HTTPS" option in the repo settings (after confirming it works)

from cockpit-project.github.io.

martinpitt avatar martinpitt commented on July 21, 2024

I locally verified that the IPs in https://help.github.com/articles/setting-up-an-apex-domain/#configuring-a-records-with-your-dns-provider work in general. Of course there is still no valid LE certificate on it, as creating that depends on the official DNS servers pointing to these IPs. But it confirms that changing DNS now won't break anything.

Right now, the IPs are still old indeed:

❱❱❱ dig A cockpit-project.org
cockpit-project.org.	55	IN	A	192.30.252.154
cockpit-project.org.	55	IN	A	192.30.252.153

@sgallagher : Can you please switch them to the four IPs that are mentioned on the above gh page?

 185.199.108.153
 185.199.109.153
 185.199.110.153
 185.199.111.153

Thanks!

from cockpit-project.github.io.

garrett avatar garrett commented on July 21, 2024

I've checked step 1. Let's see how well this works and flip the switch to enforcing in a day (or most likely: next week, due to the holiday weekend).

from cockpit-project.github.io.

sgallagher avatar sgallagher commented on July 21, 2024

So, after this propagated, I get a certificate validation failure, which is expected because the SSL cert is issued with only the following SAN values:

X509v3 Subject Alternative Name: 
                DNS:www.github.com, DNS:*.github.com, DNS:github.com, DNS:*.github.io, DNS:github.io, DNS:*.githubusercontent.com, DNS:githubusercontent.com

Connecting via https://cockpit-project.github.io works successfully for that connection, however it automatically redirects the browser to http://cockpit-project.org (non-SSL).

from cockpit-project.github.io.

larskarlitski avatar larskarlitski commented on July 21, 2024

Connecting via https://cockpit-project.github.io works successfully for that connection, however it automatically redirects the browser to http://cockpit-project.org (non-SSL).

We need to remove and re-add the custom domain to trigger a new cert. I'll do that later today to give DNS a bit more time.

from cockpit-project.github.io.

martinpitt avatar martinpitt commented on July 21, 2024

We need to remove and re-add the custom domain to trigger a new cert.

I just did that FYI, DNS looks good from here. No immediate effect yet, it might take a while?

from cockpit-project.github.io.

larskarlitski avatar larskarlitski commented on July 21, 2024

It still didn't work even though DNS returns the right IPs now for me as well. I removed and added the custom domain again.

from cockpit-project.github.io.

martinpitt avatar martinpitt commented on July 21, 2024

Still no valid certificate, so just temporarily removing and adding the custom domain is clearly not working.

from cockpit-project.github.io.

larskarlitski avatar larskarlitski commented on July 21, 2024

Apparently not. GitHub explicitly mentions this in their docs, though 😞

from cockpit-project.github.io.

garrett avatar garrett commented on July 21, 2024

I contacted GitHub support a little earlier this morning, and they just fixed it & responded back. So now we have a proper certificate, and can (probably) flip HTTPS on by default!

from cockpit-project.github.io.

garrett avatar garrett commented on July 21, 2024

I just flipped the check on, so it should be enforcing HTTPS now.

from cockpit-project.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.