Nodes value in the API might be a tad confusing about cockroach-operator HOT 9 CLOSED

Yeah, naming is one of the hardest things.

It could be CockroachDBNodes, but in such case assuming that we are already in the "cockroachdb domain" of the custom resource, it could be also reduced to nodes and although k8s has such term, I'm not convinced that it is something one would think about editing a database resource. However, replicas or something like that would be a new term which would be hard to find in the database documents or compare against non k8s install.

I would recommend to run it buy a number of people and see what they think if they see such name.

from cockroach-operator.

Fair point. let's discuss this during our next Standup.

from cockroach-operator.

Just as a comment, I chosen nodes instead of replicas as the field name because this is how CockroachDB calls its each instance in the documents. Probably, NodeCount could be a compromise.

from cockroach-operator.

@vladdy I completely understand as Nodes is a common term with databases as well.

CoachroachNodes?? or CRNodes??? I do like the count. I come from the k8s world, so whenever I talk about a DB running on top of k8s, it is fun to talk about Nodes :)

from cockroach-operator.

I would recommend to run it buy a number of people and see what they think if they see such name.

Yes run it buy some of the devops people who will use this product ;)

from cockroach-operator.

@keith-mcclellan we should think about renaming this. Also, I think this is a duplicate

from cockroach-operator.

whats the LOE on renaming? "nodes" is what we call it when provisioned outside of k8s so I want to keep that but adding a prefix to make it clear isn't a bad idea. that being said, this is a breaking change from an api perspective.

from cockroach-operator.

Replicas is the usual term. The probably is that we have k8s nodes as well

from cockroach-operator.

Closing as we are cutting a GA

from cockroach-operator.