Comments (7)
So, this is a bug thats within the 23.2 binary if you do the following sequence:
create type t as enum ('a', 'b', 'c');
BEGIN;
alter type t drop value 'c';
CREATE FUNCTION udfCall2(i int) RETURNS int LANGUAGE SQL AS $$ SELECT 1 from pg_depend where 'a'::t='a'::t $$;
COMMIT;
On 24.1 this bug is fixed, let me find the root cause on that branch.
from cockroach.
If we can't backport that, we should still be able to update the workload so it doesn't try alter type t drop value
in the mixed version state
from cockroach.
roachtest.schemachange/mixed-versions failed with artifacts on master @ c994982a8be5af89f594e115e897dd6d62cf99d8:
(mixedversion.go:592).Run: mixed-version test failure while running step 18 (run "run schemachange workload and validation in mixed version"): full command output in run_143018.312465537_n4_COCKROACHRANDOMSEED5.log: COMMAND_PROBLEM: exit status 1
test artifacts and logs in: /artifacts/schemachange/mixed-versions/run_1
Parameters:
ROACHTEST_arch=amd64
ROACHTEST_cloud=gce
ROACHTEST_coverageBuild=false
ROACHTEST_cpu=4
ROACHTEST_encrypted=false
ROACHTEST_metamorphicBuild=false
ROACHTEST_ssd=0
Same failure on other branches
- #120975 roachtest: schemachange/mixed-versions failed [C-test-failure O-roachtest O-robot T-sql-foundations branch-release-23.1.17-custom-v2 release-blocker]
- #120972 roachtest: schemachange/mixed-versions failed [C-test-failure O-roachtest O-robot T-sql-foundations branch-release-23.1 release-blocker]
- #119904 roachtest: schemachange/mixed-versions failed [job-rows-batch-insert error; let's ignore that error] [C-test-failure O-roachtest O-robot P-3 T-sql-foundations branch-release-23.1.17-rc]
This test on roachdash | Improve this report!
from cockroach.
"BEGIN",
{
"sql": "CREATE SCHEMA schema_w1_173 AUTHORIZATION root"
},
"COMMIT"
],
"expectedExecErrors": "",
"expectedCommitErrors": "",
"message": ""
}
{
"workerId": 4,
"clientTimestamp": "14:30:26.255471",
"ops": [
"BEGIN",
{
"sql": "ALTER TYPE schema_w4_62.enum_w0_136 DROP VALUE 'ds'"
},
{
"sql": "CREATE FUNCTION schema_w2_3.udf_w4_165(enum_0 schema_w4_9.enum_w0_51, enum_1 schema_w4_9._enum_w0_51, enum_2 schema_w4_62.enum_w0_136)\n\tRETURNS VOID\n\tLANGUAGE SQL\n\tAS $$ SELECT NULL WHERE ('da'::schema_w4_9.enum_w0_51 IS NULL) AND ('dsfas'::schema_w4_62.enum_w0_136 IS NULL) $$"
},
"COMMIT"
],
"expectedExecErrors": "",
"expectedCommitErrors": "",
"message": "***UNEXPECTED COMMIT ERROR; Received an unexpected commit error: ERROR: transaction committed but schema change aborted with error: (42P01): could not validate enum value removal for \"ds\": relation \"[426]\" does not exist (SQLSTATE 42P01)"
from cockroach.
This might relate to UDF dependency tracking; @fqazi could you check?
from cockroach.
This was addressed by: #118780. @rimadeodhar Is there any danger if we back port this change, since its easy to hit this bug in 23.2? I can get that open.
An even simpler repro:
create type t as enum ('a', 'b', 'c');
CREATE FUNCTION udfCall2(i int) RETURNS int LANGUAGE SQL AS $$ SELECT 1 from pg_depend where 'a'::t='a'::t $$;
alter type t drop value 'c';
from cockroach.
Yeah, we can backport it.
from cockroach.
Related Issues (20)
- roachtest: cluster_creation failed
- roachtest: schemachange/leasing-benchmark failed HOT 2
- kv/kvserver: TestRangefeedCheckpointsRecoverFromLeaseExpiration failed HOT 1
- opt: do not blanket-exempt partial indexes from disallow_full_table_scans
- roachtest: tpcc/mixed-headroom/n5cpu16 failed
- roachtest: add a new large schema benchmark which can be used to explore object limits
- roachtest: extend large schema benchmark into multi-region
- sql: explicit zone configuration for the timeseries range on a new cluster
- sql: TestExplainRedact failed HOT 1
- roachtest: test server endpoints in large schema benchmark
- online restore: limit disk bandwidth used by downloads in mb/s to avoid starving wal syncs HOT 2
- roachprod: support zfs vms for azure and aws HOT 1
- Update scheduled changefeeds to pause if resumed on a different cluster HOT 1
- roachprod: support specifying SSD count on azure and aws
- sql: full scans of virtual tables don't error out with `disallow_full_table_scans`
- catalog/lease: transactions are not producing deadline errors when they should HOT 1
- pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test: TestLogic_upgrade_skip_version failed HOT 1
- pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test: TestLogic_mixed_version_sequence_per_node_cache failed HOT 1
- Sentry: fold_constants_funcs.go:677: function current_schema() not defined (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/opt/norm... HOT 1
- roachtest: backup-restore/mixed-version failed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cockroach.