Giter VIP home page Giter VIP logo

Comments (7)

fqazi avatar fqazi commented on June 26, 2024 1

So, this is a bug thats within the 23.2 binary if you do the following sequence:

create type t as enum ('a', 'b', 'c');
BEGIN;
alter type t drop  value 'c';
CREATE FUNCTION udfCall2(i int) RETURNS int LANGUAGE SQL AS $$ SELECT 1 from pg_depend where 'a'::t='a'::t $$;
COMMIT;

On 24.1 this bug is fixed, let me find the root cause on that branch.

from cockroach.

rafiss avatar rafiss commented on June 26, 2024 1

If we can't backport that, we should still be able to update the workload so it doesn't try alter type t drop value in the mixed version state

from cockroach.

cockroach-teamcity avatar cockroach-teamcity commented on June 26, 2024

roachtest.schemachange/mixed-versions failed with artifacts on master @ c994982a8be5af89f594e115e897dd6d62cf99d8:

(mixedversion.go:592).Run: mixed-version test failure while running step 18 (run "run schemachange workload and validation in mixed version"): full command output in run_143018.312465537_n4_COCKROACHRANDOMSEED5.log: COMMAND_PROBLEM: exit status 1
test artifacts and logs in: /artifacts/schemachange/mixed-versions/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

  • #120975 roachtest: schemachange/mixed-versions failed [C-test-failure O-roachtest O-robot T-sql-foundations branch-release-23.1.17-custom-v2 release-blocker]
  • #120972 roachtest: schemachange/mixed-versions failed [C-test-failure O-roachtest O-robot T-sql-foundations branch-release-23.1 release-blocker]
  • #119904 roachtest: schemachange/mixed-versions failed [job-rows-batch-insert error; let's ignore that error] [C-test-failure O-roachtest O-robot P-3 T-sql-foundations branch-release-23.1.17-rc]

This test on roachdash | Improve this report!

from cockroach.

annrpom avatar annrpom commented on June 26, 2024
  "BEGIN",
  {
   "sql": "CREATE SCHEMA schema_w1_173 AUTHORIZATION root"
  },
  "COMMIT"
 ],
 "expectedExecErrors": "",
 "expectedCommitErrors": "",
 "message": ""
}
{
 "workerId": 4,
 "clientTimestamp": "14:30:26.255471",
 "ops": [
  "BEGIN",
  {
   "sql": "ALTER TYPE schema_w4_62.enum_w0_136 DROP VALUE 'ds'"
  },
  {
   "sql": "CREATE FUNCTION schema_w2_3.udf_w4_165(enum_0 schema_w4_9.enum_w0_51, enum_1 schema_w4_9._enum_w0_51, enum_2 schema_w4_62.enum_w0_136)\n\tRETURNS VOID\n\tLANGUAGE SQL\n\tAS $$ SELECT NULL WHERE ('da'::schema_w4_9.enum_w0_51 IS NULL) AND ('dsfas'::schema_w4_62.enum_w0_136 IS NULL) $$"
  },
  "COMMIT"
 ],
 "expectedExecErrors": "",
 "expectedCommitErrors": "",
 "message": "***UNEXPECTED COMMIT ERROR; Received an unexpected commit error: ERROR: transaction committed but schema change aborted with error: (42P01): could not validate enum value removal for \"ds\": relation \"[426]\" does not exist (SQLSTATE 42P01)"

from cockroach.

rafiss avatar rafiss commented on June 26, 2024

This might relate to UDF dependency tracking; @fqazi could you check?

from cockroach.

fqazi avatar fqazi commented on June 26, 2024

This was addressed by: #118780. @rimadeodhar Is there any danger if we back port this change, since its easy to hit this bug in 23.2? I can get that open.

An even simpler repro:

create type t as enum ('a', 'b', 'c');
CREATE FUNCTION udfCall2(i int) RETURNS int LANGUAGE SQL AS $$ SELECT 1 from pg_depend where 'a'::t='a'::t $$;
alter type t drop  value 'c';

from cockroach.

rimadeodhar avatar rimadeodhar commented on June 26, 2024

Yeah, we can backport it.

from cockroach.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.