Comments (3)
mgartner
commented on August 26, 2024
WARNING: DATA RACE
Read at 0x00c0111e5228 by goroutine 713:
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/ssmemstorage.(*Container).PopAllStats()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/ssmemstorage/ss_mem_storage.go:648 +0xa29
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/sslocal.(*SQLStats).ConsumeStats()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/sslocal/sslocal_provider.go:167 +0x4f0
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats.(*PersistedSQLStats).Flush()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats/pkg/sql/sqlstats/persistedsqlstats/flush.go:89 +0xb2c
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats.(*PersistedSQLStats).startSQLStatsFlushLoop.func1()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats/pkg/sql/sqlstats/persistedsqlstats/provider.go:197 +0x4bc
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:485 +0x262
Previous write at 0x00c0111e5228 by goroutine 4021:
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/ssmemstorage.(*Container).RecordTransaction()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/ssmemstorage/ss_mem_writer.go:340 +0x3a5
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats.(*ApplicationStats).RecordTransaction.func1()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats/pkg/sql/sqlstats/persistedsqlstats/appStats.go:60 +0xf7
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats.(*ApplicationStats).recordStatsOrSendMemoryPressureSignal()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats/pkg/sql/sqlstats/persistedsqlstats/appStats.go:65 +0x2f
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats.(*ApplicationStats).RecordTransaction()
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/persistedsqlstats/pkg/sql/sqlstats/persistedsqlstats/appStats.go:59 +0xe4
github.com/cockroachdb/cockroach/pkg/sql/sqlstats/sslocal.(*StatsCollector).RecordTransaction()
<autogenerated>:1 +0xd6
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).recordTransactionFinish()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:3412 +0xfb3
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).onTxnFinish()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:3232 +0x53b
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).resetExtraTxnState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2079 +0xca4
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).txnStateTransitionsApplyWrapper()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:4021 +0x106a
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2532 +0x1e79
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2206 +0x3ea
github.com/cockroachdb/cockroach/pkg/sql.(*optPlanningCtx).buildExecMemo()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:599 +0x844
github.com/cockroachdb/cockroach/pkg/sql.(*planner).makeOptimizerPlan()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:250 +0x1f8
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).makeExecPlan()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2363 +0x125
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1833 +0xccb
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1166 +0x8c93
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:146 +0x184
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithProfiling()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:3489 +0x539
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:145 +0x89d
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2284 +0x94b
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2289 +0x1378
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2206 +0x3ea
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).Build()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:255 +0x689
github.com/cockroachdb/cockroach/pkg/sql.(*optPlanningCtx).buildExecMemo()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:599 +0x844
github.com/cockroachdb/cockroach/pkg/sql.(*planner).makeOptimizerPlan()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:250 +0x1f8
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).makeExecPlan()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2363 +0x125
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1833 +0xccb
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1166 +0x8c93
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:146 +0x184
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithProfiling()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:3489 +0x539
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:145 +0x89d
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd.func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2284 +0x94b
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2289 +0x1378
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2206 +0x3ea
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb.(*ElementCollection[go.shape.interface { MarshalTo([]uint8) (int, error); MarshalToSizedBuffer([]uint8) (int, error); ProtoMessage(); Reset(); Size() int; String() string; Unmarshal([]uint8) error; github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb.element() }]).genericFilter()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb/pkg/sql/schemachanger/scpb/element_collection.go:134 +0x281
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl.walk.func4()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl/walk.go:123 +0x3f9
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl.walk()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl/walk.go:140 +0x478
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl.WalkDescIDs()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl/walk.go:26 +0x148
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl.ContainsDescID()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/screl/scalars.go:87 +0xa4
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.undroppedBackrefs.func1()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/helpers.go:259 +0x12
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.undroppedBackrefs.(*ElementCollection[go.shape.interface { MarshalTo([]uint8) (int, error); MarshalToSizedBuffer([]uint8) (int, error); ProtoMessage(); Reset(); Size() int; String() string; Unmarshal([]uint8) error; github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb.element() }]).Filter.func2()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb/pkg/sql/schemachanger/scpb/element_collection.go:101 +0xa2
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb.(*ElementCollection[go.shape.interface { MarshalTo([]uint8) (int, error); MarshalToSizedBuffer([]uint8) (int, error); ProtoMessage(); Reset(); Size() int; String() string; Unmarshal([]uint8) error; github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb.element() }]).genericFilter()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb/pkg/sql/schemachanger/scpb/element_collection.go:134 +0x281
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb.(*ElementCollection[go.shape.interface { MarshalTo([]uint8) (int, error); MarshalToSizedBuffer([]uint8) (int, error); ProtoMessage(); Reset(); Size() int; String() string; Unmarshal([]uint8) error; github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb.element() }]).Filter()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb/pkg/sql/schemachanger/scpb/element_collection.go:99 +0xec
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.undroppedBackrefs()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/helpers.go:258 +0x12
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.walkDropColumnDependencies()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/alter_table_drop_column.go:407 +0x5d2
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.dropColumn()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/alter_table_drop_column.go:206 +0x484
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.alterTableDropColumn()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/alter_table_drop_column.go:48 +0x22c
runtime.call64()
src/runtime/asm_amd64.s:772 +0x42
reflect.Value.Call()
GOROOT/src/reflect/value.go:380 +0xb5
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.AlterTable()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/alter_table.go:137 +0x73b
runtime.call32()
src/runtime/asm_amd64.s:771 +0x42
reflect.Value.Call()
GOROOT/src/reflect/value.go:380 +0xb5
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt.Process()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/internal/scbuildstmt/process.go:188 +0x5b4
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild.Build()
github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild/build.go:99 +0x70d
github.com/cockroachdb/cockroach/pkg/sql.(*planner).SchemaChange()
github.com/cockroachdb/cockroach/pkg/sql/schema_change_plan_node.go:72 +0x478
github.com/cockroachdb/cockroach/pkg/sql.buildOpaque()
github.com/cockroachdb/cockroach/pkg/sql/opaque.go:57 +0x345
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).tryBuildOpaque()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/opaque.go:70 +0x23a
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildStmt()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:467 +0x1137
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRootWithScope()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:295 +0x2fa
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:276 +0x1ea
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).Build()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:255 +0x689
github.com/cockroachdb/cockroach/pkg/sql.(*optPlanningCtx).buildExecMemo()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:599 +0x844
github.com/cockroachdb/cockroach/pkg/sql.(*planner).makeOptimizerPlan()
github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:250 +0x1f8
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).makeExecPlan()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2363 +0x125
from cockroach.
mgartner
commented on August 26, 2024
This is a duplicate of #121888. The fix in #122028 has not yet been backported to release-24.1. The backport PR is #122039.
from cockroach.
mgartner
commented on August 26, 2024
Backport has been merged. Closing.
from cockroach.
Related Issues (20)
- roachtest: cdc/kafka-azure failed HOT 26
- roachtest: lease-preferences/manual-violating-transfer failed
- roachtest: ssh_problem failed
- pkg/sql/copy/copy_test: TestCopyFromRandom failed HOT 1
- ccl/backupccl: TestBackupRestoreSystemUsers failed
- sql/stats: TestCreateStatsProgress failed HOT 1
- roachtest: cluster_creation failed HOT 1
- pkg/ccl/testccl/workload/schemachange/schemachange_test: TestWorkload failed
- Sentry: typing.go:84: inconsistent Case return types × × (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.InferWhensType ... HOT 1
- roachtest: decommissionBench/nodes=6/warehouses=1000/drain-first/while-upreplicating/target=3/multi-region failed HOT 1
- Sentry: logstore.go:496: there is a gap at index 7957689452319564909 (1) attached stack trace -- stack trace: | runtime.gopanic | GOROOT/src/runtime/panic.go:884 | [...repeated from below...]...
- roachtest: open_ports failed HOT 1
- changefeedccl: breaking behavior change between pubsub v1 and v2 HOT 2
- roachtest: import/tpcc/warehouses=4000/geo failed HOT 1
- bundle: recreating a bundle with UDTs in a non-default database doesn't work
- bundle: presence of custom zone configs breaks recreation
- sql/catalog/lease: remove use of `skip.NightlyStress`
- util/startup: `TestStartupFailureRandomRange` is never run HOT 1
- *: evaluate uses of `skip.Stress()` HOT 1
- storage: dynamically determine store capacity if maxSize is specified as a percentage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cockroach.