Comments (5)
@Vidyap23 sure, feel free to submit a PR. Review our contribution guidelines here: https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/73072641/What+is+a+Good+CockroachDB+PR
I recommend fixing this by modifying the MergeWith
function so that it accepts a SearchPath parameter.
cockroach/pkg/sql/sem/tree/function_definition.go
Lines 236 to 238 in 41cb974
When it combines the two lists, it should make sure they are ordered by the order the schemas appear when using SearchPath.Iter()
.
To test this, you can use the example that @michae2 wrote above. You can add that test to pkg/sql/logictest/testdata/logic_test/udf
.
from cockroach.
I haven't looked into what the code is doing right now, but the thing we want it to use when resolving the name is (sessiondata.SearchPath).Iter()
:
cockroach/pkg/sql/sessiondata/search_path.go
Lines 133 to 159 in d4957b3
from cockroach.
The code that needs to be fixed is:
cockroach/pkg/sql/schema_resolver.go
Lines 455 to 467 in 45771c6
as well as possibly other implementations of ResolveFunction
. I think the MergeWith
function should be updated so that it orders the overloads by search path.
from cockroach.
Hi @rafiss I would like to work on this issue, if no one has picked it up yet
from cockroach.
@michae2 @rafiss
Hi, I just opened a pr #126048 to fix this issue, can you take a look and give some suggestions? Thanks a lot!
from cockroach.
Related Issues (20)
- sql/privileges: add a unit test to ensure no system privilege is introduced without a equivalent read-only privilege
- sql/schemachanger: support trivial ALTER COLUMN ... SET TYPE in declarative schema changer
- pkg/sql/logictest/tests/cockroach-go-testserver-23.1/cockroach-go-testserver-23_1_test: TestLogic_mixed_version_udf_execute_privileges failed HOT 1
- acceptance: TestDockerCLI_test_replication_protocol failed [unable to apply cgroup configuration] HOT 1
- ui: add on demand debug info to sql activity pages
- kv: improve deadlock observability
- Sentry: logical_props_builder.go:1699: comparison overload not found (×, ×, ×) (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/o... HOT 2
- Sentry: logical_props_builder.go:1699: comparison overload not found (×, ×, ×) (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/o... HOT 1
- util/log: TestMessageReceived failed HOT 1
- util/log: TestHTTPSinkHeadersAndCompression failed HOT 1
- pkg/sql/logictest/tests/cockroach-go-testserver-23.2/cockroach-go-testserver-23_2_test: TestLogic_mixed_version_sequence_per_node_cache failed HOT 1
- pkg/ccl/testccl/sqlccl/sqlccl_test: TestExplainRedactDDL failed HOT 1
- roachtest: asyncpg failed HOT 2
- roachtest: backup-restore/mixed-version failed HOT 2
- roachtest: unoptimized-query-oracle: precision issues with `abs` on FLOAT4 in virtual computed column HOT 10
- roachtest: failover/chaos/read-only failed HOT 4
- Comparison overload not found (ge, int[], string[]) HOT 4
- roachtest: unoptimized-query-oracle/disable-rules=half/seed-multi-region failed HOT 1
- schemachanger: make merge phase more contention-aware HOT 2
- storeliveness: add documentation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cockroach.