Giter VIP home page Giter VIP logo

Comments (2)

blathers-crl avatar blathers-crl commented on August 16, 2024

Hi @osmes, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

from cockroach.

rafiss avatar rafiss commented on August 16, 2024

This looks like it should be fixed in the frontend. The code here is assuming that info.Options will be set.

cockroach/pkg/ui/workspaces/db-console/src/util/events.ts

Lines 180 to 181 in 9e61527

case eventTypes.ALTER_ROLE:
return `Role Altered: User ${info.User} altered role ${info.RoleName} with options ${info.Options}`;

But for ALTER ROLE ... SET, we only populate info.SetInfo:

cockroach/pkg/sql/alter_role.go

Lines 501 to 506 in c4065c0

return params.p.logEvent(params.ctx,
0, /* no target */
&eventpb.AlterRole{
RoleName: roleName.Normalized(),
SetInfo: []string{"DEFAULTSETTINGS"},
})

This was done in 0a0271c.

Before that, this would get logged similar to other ALTER ROLE statements:

cockroach/pkg/sql/alter_role.go

Lines 270 to 275 in c4065c0

return params.p.logEvent(params.ctx,
0, /* no target */
&eventpb.AlterRole{
RoleName: n.roleName.Normalized(),
Options: optStrs,
})

Changing the frontend code to check if info.Options is defined sounds like the right fix.

from cockroach.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.