Describe the problem Users of the protected timesta

I believe this is a similar request to <a class="issue-link js-issue-link" data-error-

It seems that when this was being implemented (in <a class="issue-link js-issue-link"

protectedts: MakeSchemaObjectsTarget should protect the schema object's metadata about cockroach HOT 3 OPEN

stevendanna commented on August 17, 2024

protectedts: MakeSchemaObjectsTarget should protect the schema object's metadata

from cockroach.

Comments (3)

stevendanna commented on August 17, 2024

This is written more as an "enhancement". I labelled it "bug" because I am almost certain that we have at least 1 CDC bug related to the existing API.

from cockroach.

rafiss commented on August 17, 2024

I believe this is a similar request to #120391. For now, we likely won't prioritize it unless we hear of a bug that needs this to be addressed in order to fix the bug.

from cockroach.

rafiss commented on August 17, 2024

It seems that when this was being implemented (in #74248), that the decision was made to have the user of the PTS decide if they wanted to protect the system.descriptors table as well. Our team wasn't involved in the design of this, so I don't know for sure, but I'm basing this off of this block of code, which shows changefeeds opting-in to protecting system.descriptors rather than assuming that it will get protected automatically:

cockroach/pkg/ccl/changefeedccl/protected_timestamps.go

Lines 45 to 56 in 8c7a79c

 func makeTargetToProtect(targets changefeedbase.Targets) *ptpb.Target { 

 // NB: We add 1 because we're also going to protect system.descriptors. 

 // We protect system.descriptors because a changefeed needs all of the history 

 // of table descriptors to version data. 

 tablesToProtect := make(descpb.IDs, 0, targets.NumUniqueTables()+1) 

 _ = targets.EachTableID(func(id descpb.ID) error { 

 tablesToProtect = append(tablesToProtect, id) 

 return nil 

 }) 

 tablesToProtect = append(tablesToProtect, keys.DescriptorTableID) 

 return ptpb.MakeSchemaObjectsTarget(tablesToProtect) 

 }

from cockroach.

protectedts: MakeSchemaObjectsTarget should protect the schema object's metadata about cockroach HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func makeTargetToProtect(targets changefeedbase.Targets) *ptpb.Target {
	// NB: We add 1 because we're also going to protect system.descriptors.
	// We protect system.descriptors because a changefeed needs all of the history
	// of table descriptors to version data.
	tablesToProtect := make(descpb.IDs, 0, targets.NumUniqueTables()+1)
	_ = targets.EachTableID(func(id descpb.ID) error {
	tablesToProtect = append(tablesToProtect, id)
	return nil
	})
	tablesToProtect = append(tablesToProtect, keys.DescriptorTableID)
	return ptpb.MakeSchemaObjectsTarget(tablesToProtect)
	}