Comments (2)
annrpom
commented on August 27, 2024
we would also want to re-add this check in setColumnDefault
cockroach/pkg/workload/schemachange/operation_generator.go
Lines 2290 to 2293 in a74f876
back in to our workload
// Generated columns cannot have default values.
if columnForDefault.generated {
stmt.expectedExecErrors.add(pgcode.InvalidTableDefinition)
}
from cockroach.
annrpom
commented on August 27, 2024
Oh -- we seem to do this in legacy with a non-null default:
alter table t alter column generated_value set default 42;
ERROR: relation "t" (112): computed column "generated_value" cannot also have a DEFAULT expression
SQLSTATE: 42P16
The declarative schema changer doesn't have something as legible:
[email protected]:26257/demoapp/movr> alter table t alter column generated_value set default 42;
ERROR: error executing StatementPhase stage 1 of 1 with 1 MutationType op: relation "t" (112): computed column "generated_value" cannot also have a DEFAULT expression
SQLSTATE: 42P16
from cockroach.
Related Issues (20)
- Sentry: conn_executor.go:900: panic: × (1) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1 | github.com/cockroachdb/cockroach/pkg/sql/... HOT 1
- roachtest: ruby-pg failed
- pkg/sql/logictest/tests/cockroach-go-testserver-upgrade-to-master/cockroach-go-testserver-upgrade-to-master_test: TestLogic_mixed_version_schedule_details failed HOT 1
- kvserver: support removal of a store from a node HOT 7
- : failed
- ccl/backupccl: TestShowBackup failed
- bench/rttanalysis: TestBenchmarkExpectation failed
- pkg/ccl/logictestccl/tests/fakedist/fakedist_test: TestCCLLogic_show_create failed
- roachtest: restore/tpce/400GB/aws/nodes=4/cpus=8 failed
- roachtest: ycsb/C/nodes=3 failed
- roachtest: monitor_failure failed
- roachtest: add operation name as a datadog tag HOT 1
- pkg/sql/logictest/tests/cockroach-go-testserver-23.1/cockroach-go-testserver-23_1_test: TestLogic_mixed_version_procedure failed HOT 1
- roachtest: failover/chaos/read-write failed
- ccl/changefeedccl: TestChangefeedRandomExpressions failed
- Sentry: histogram.go:254: the first bucket should have NumRange=0 (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/opt/props.(*Histo... HOT 2
- Sentry: histogram.go:254: the first bucket should have NumRange=0 (1) assertion failure Wraps: (2) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/sql/opt/props.(*Histo... HOT 2
- sql/schemachange: TestColumnConversions failed
- kv/kvserver/rangelog: TestRangeLog failed
- changefeedccl: improve observability into blocking buffer quota issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cockroach.