Comments (3)
jbowens
commented on August 20, 2024
===== SEED =====
1715490363514105400
===== DIFF =====
/artifacts/meta/240512-050603.5143181144998/{standard-000,random-013}
@@ -1197,11 +1197,11 @@
iter10 = db1.NewIter("", "", 2 /* key types */, 0, 0, false /* use L6 filters */, "" /* masking suffix */) // <nil> #1196
db1.Set("upqpcz@2", "rlnhf") // <nil> #1197
iter10.SeekPrefixGE("mgheqkv@6") // [true,"mgheqkv@6",<no point>,["mgheqkv","mgheqkv\x00")=>{"@6"="chyitvknodlqcvfbgesk"}*] <nil> #1198
db1.Delete("kucaygxoh") // <nil> #1199
iter9.NextPrefix() // [true,"bxoeqyxe",<no point>,["bxoeqyxe","drfw")=>{"@6"="vjgtofxwbbhuyfpwy","@4"="ucvjaaiedhdmm"}*] <nil> #1200
-iter10.SeekPrefixGE("uznszonw@4") // [true,"uznszonw@4","uychbstvqto",<no range>*] <nil> #1201
+iter10.SeekPrefixGE("uznszonw@4") // [false] <nil> #1201
iter10.Next("") // [false] <nil> #1202
iter10.Prev("") // [false] pebble: unsupported reverse prefix iteration #1203
db1.Delete("bxoeqyxe@1") // <nil> #1204
db1.DeleteRange("isycphwfdbbh@5", "ohzblxra") // <nil> #1205
iter9.Next("") // [true,"fcqygccosb",<no point>,["fcqygccosb","pzelvmwgzp")=>{"@6"="chyitvknodlqcvfbgesk"}*] <nil> #1206
Can reproduce the errant run easily with
go test -tags invariants -v -run TestMeta$ -run-dir ~/Downloads/Nightlies_Nightly_Pebble_Metamorphic_28547_artifacts/meta/240512-050603.5143181144998/random-013 -fail 'false.*#1201$' -max-threads 1 | grep -B 100 '#1201$'
from pebble.
cockroach-teamcity
commented on August 20, 2024
github.com/cockroachdb/pebble/internal/metamorphic.TestMeta failed with artifacts on refs/heads/master @ 5ee10bd4b992:
db1.IngestExternalFiles(external0, "cmvuwqzcyhibrt" /* start */, "cmvuwqzcyhibrtzm" /* end */, "@327" /* syntheticSuffix */, "cm" /* syntheticPrefix */)
db1.IngestExternalFiles(external0, "plrvuwqzcyhibrt" /* start */, "plrvuwqzcyhibrty" /* end */, "" /* syntheticSuffix */, "plr" /* syntheticPrefix */)
db1.IngestExternalFiles(external0, "vuwqzcyhibrt" /* start */, "vuwqzcyhibrtngs" /* end */, "" /* syntheticSuffix */, "" /* syntheticPrefix */)
db1.Get("rbbzby@15")
db1.Close()
To reduce: go test ./internal/metamorphic -tags invariants -run 'TestMeta$' --compare "/artifacts/meta/240513-055300.7043438092545/{standard-000,random-006}" --try-to-reduce -v
=== RUN TestMeta/execution/random-011
=== PAUSE TestMeta/execution/random-011
=== CONT TestMeta/execution/random-011
=== RUN TestMeta/execution/random-022
=== PAUSE TestMeta/execution/random-022
=== CONT TestMeta/execution/random-022
=== RUN TestMeta/execution/standard-010
=== PAUSE TestMeta/execution/standard-010
=== CONT TestMeta/execution/standard-010
=== RUN TestMeta/execution/standard-013
=== PAUSE TestMeta/execution/standard-013
=== CONT TestMeta/execution/standard-013
=== RUN TestMeta/execution/standard-018
=== PAUSE TestMeta/execution/standard-018
=== CONT TestMeta/execution/standard-018
=== RUN TestMeta/execution/standard-026
=== PAUSE TestMeta/execution/standard-026
=== CONT TestMeta/execution/standard-026
=== RUN TestMeta/compare/random-005
=== RUN TestMeta/compare/standard-015
=== RUN TestMeta/compare/standard-016
=== RUN TestMeta/compare/standard-020
=== RUN TestMeta/compare/standard-026
=== RUN TestMeta/execution/random-021
=== PAUSE TestMeta/execution/random-021
=== CONT TestMeta/execution/random-021
=== RUN TestMeta/execution/standard-012
=== PAUSE TestMeta/execution/standard-012
=== CONT TestMeta/execution/standard-012
=== RUN TestMeta/execution/standard-014
=== PAUSE TestMeta/execution/standard-014
=== CONT TestMeta/execution/standard-014
=== RUN TestMeta/compare/standard-001
=== RUN TestMeta/compare/standard-011
=== RUN TestMeta/execution/random-007
=== PAUSE TestMeta/execution/random-007
=== CONT TestMeta/execution/random-007
=== RUN TestMeta/execution/random-012
=== PAUSE TestMeta/execution/random-012
=== CONT TestMeta/execution/random-012
=== RUN TestMeta/execution/random-017
=== PAUSE TestMeta/execution/random-017
=== CONT TestMeta/execution/random-017
Help
To reproduce, try:
go test -tags 'invariants' -exec 'stress -p 1' -timeout 0 -test.v -run 'TestMeta$' ./internal/metamorphic -seed 1715579580704542328 -ops "uniform:5000-10000"This test on roachdash | Improve this report!
from pebble.
jbowens
commented on August 20, 2024
This is a side effect of #3596 with an interaction of TrySeekUsingNext:
During this operation:
iter10.SeekPrefixGE("mgheqkv@6") // [true,"mgheqkv@6",<no point>,["mgheqkv","mgheqkv\x00")=>{"@6"="chyitvknodlqcvfbgesk"}*] <nil> #1198
- We position a levelIter onto
000089:[crmuudvmizei@1#355,DEL-zrogino@5#361,MERGE]and return a range deletion start boundary key:mgheqkv@6#72057594037927935,RANGEDEL. - The merging iterator steps the levelIter onto the range deletion end boundary key:
mgheqkv@1#72057594037927935,RANGEDEL. - The merging iterator steps the levelIter off the range deletion end boundary key, exhausting the levelIter's internal iterator (because bloom filters excluded the remaining point keys in the file). This moves on to the next file in the level, but there isn't one, exhausting the manifest.LevelIterator.
Then during the diverging operation iter10.SeekPrefixGE("uznszonw@4"):
- We perform a
levelIter.SeekPrefixGE("uznszonw", "uznszonw@4", TrySeekUsingNext()=true) findFileGEfinds that we've already exhausted the level iterator and returns nil, missing a relevant point key in000089.
We need to not move the levelIter beyond the file 000089, but when performing the levelIter.Next don't today have context that we're in prefix iteration mode and that we shouldn't progress to the next file.
from pebble.
Related Issues (20)
- github.com/cockroachdb/pebble/internal/metamorphic: TestMetaTwoInstance failed
- don't use filter blocks for large flushable ingests HOT 1
- smart filter block loading
- improve performance of aggregations over a key range using range annotations
- db: strictly enforce prefix in internalIterator.SeekPrefixGE
- sstable: show filenum when sstable metadata is corrupted
- db: shared compaction concurrency limit across multiple Pebble instances HOT 2
- db: add ability to excise without ingest HOT 1
- github.com/cockroachdb/pebble/internal/metamorphic: TestMeta failed HOT 10
- add ValidateKey method to comparer
- ingest: verify ingestion sstables have legal boundary range keys
- internal/metamorphic/crossversion/crossversion_test: TestMetaCrossVersion failed HOT 1
- Backup HOT 1
- cmd/pebble: nightly benchmarks failing
- db: Open fails with 'open : no such file or directory' HOT 2
- db: assert that ingested sstables with synthetic suffixes have no duplicate keys
- Release fix for MIPS32 support HOT 5
- *: remove instances of go:linkname throughout
- tool: wal dump requires .log in current working directory
- wal: reader batch corruption
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pebble.