Refactor `plugins.rb` into one command class per file about cocoapods-plugins HOT 7 CLOSED

Actually, looking at cocoapods/command/lib.rb it appears this is the standard for CLAide commands in the main pods gem.

from cocoapods-plugins.

So what, should we keep everything in one big file like for the pod lib command that only lies in lib.rb?

I suggest that we split it anyways, contrary to the structure used in the main pods gem.

• The main pod gem has a lot of commands, and creating a subfolder and separate .rb files would create a lot of files and hierarchy levels, that is probably why they didn't do it
• Here we are in a plugin, which as way much less code and is a much smaller project, so keeping it readable with more but smaller files seems a good idea

I was willing to start the refactoring, but will wait for your advice about which way to go, splitting in separate files or keeping it all in a big single one.

from cocoapods-plugins.

In our case, the search command is quite different in function compared
to the create command so I'd rather separate those two classes.

On Tue, Apr 29, 2014 at 3:33 PM, AliSoftware [email protected]:

So what, should we keep everything in one big file like for the pod libcommand that only lies in
lib.rb?

I suggest that we split it anyways, contrary to the structure used in the
main pods gem.

• The main pod gem has a lot of commands, and creating a subfolder and
  separate .rb files would create a lot of files and hierarchy levels,
  that is probably why they didn't do it
• Here we are in a plugin, which as way much less code and is a much
  smaller project, so keeping it readable with more but smaller files seems a
  good idea

I was willing to start the refactoring, but will wait for your advice
about which way to go, splitting in separate files or keeping it all in a
big single one.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-41721576
.

from cocoapods-plugins.

D'oh! Reply by email may not be as good an idea as I thought.

from cocoapods-plugins.

I vote for refactoring everything... also the main gem! ☀️

from cocoapods-plugins.

@irrationalfab 👍

I'm beginning to like submitting ruby PRs… even as a ruby newbie (I'm an iOS expert to begin with, not a ruby programmer at all), so maybe I'll give it a try on the main gem sometime 😉

from cocoapods-plugins.

@AliSoftware Looking forward to it!

from cocoapods-plugins.