Giter VIP home page Giter VIP logo

Comments (10)

dbgrandi avatar dbgrandi commented on June 15, 2024

Back to passing on 1.8.7 and 2.x as of 110d18e

from cocoapods-plugins.

fabiopelosin avatar fabiopelosin commented on June 15, 2024

It is broken again:

$ rake spec
// [...]
NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::Plugins::List - prints out all plugins
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:128:in `plugin_title'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:75:in `print_plugin'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:26:in `run'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:25:in `each'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:25:in `run'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/CocoaPods/lib/cocoapods/user_interface.rb:91:in `title'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:24:in `run'
    ./spec/command/plugins/list_spec.rb:23
    ./spec/command/plugins/list_spec.rb:21
    ./spec/command/plugins/list_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::Plugins::Search - should filter plugins only by name without full search
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:128:in `plugin_title'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:75:in `print_plugin'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:52:in `run'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `each'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `run'
    ./spec/command/plugins/search_spec.rb:40
    ./spec/command/plugins/search_spec.rb:37
    ./spec/command/plugins/search_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::Plugins::Search - should filter plugins by name, author, description with full search
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:128:in `plugin_title'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:75:in `print_plugin'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:52:in `run'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `each'
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `run'
    ./spec/command/plugins/search_spec.rb:49
    ./spec/command/plugins/search_spec.rb:46
    ./spec/command/plugins/search_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::GemHelper - detects if a gem is installed
    ./spec/command/gem_helper_spec.rb:16
    ./spec/command/gem_helper_spec.rb:15
    ./spec/command/gem_helper_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/fabio/Documents/Projects/irrationalfab/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::GemHelper - detects if a specific version of a gem is installed
    ./spec/command/gem_helper_spec.rb:21
    ./spec/command/gem_helper_spec.rb:20
    ./spec/command/gem_helper_spec.rb:6

NameError: uninitialized constant Gem::NameTuple
    ./spec/command/gem_helper_spec.rb:27: Pod::Command::GemHelper - creates a version list that includes all versions of a single gem
    ./spec/command/gem_helper_spec.rb:26
    ./spec/command/gem_helper_spec.rb:6

Bacon::Error: "\e[32m\n[!] using template 'https://github.com/CocoaPods/cocoapods-plugin-template.git'\e[0m\n\e[32m\n[!] Don't forget to create a Pull Request on https://github.com/CocoaPods/cocoapods.org\n to add your plugin to the plugins.json file once it is released!\e[0m\n".include?("Creating `cocoapods-unprefixed` plugin") failed
    ./spec/command/plugins/create_spec.rb:51: Pod::Command::Plugins::Create - should prefix the given name if not already
    ./spec/command/plugins/create_spec.rb:44
    ./spec/command/plugins/create_spec.rb:7

Bacon::Error: "\e[32m\n[!] using template 'https://github.com/CocoaPods/cocoapods-plugin-template.git'\e[0m\n\e[32m\n[!] Don't forget to create a Pull Request on https://github.com/CocoaPods/cocoapods.org\n to add your plugin to the plugins.json file once it is released!\e[0m\n".include?("Creating `cocoapods-prefixed` plugin") failed
    ./spec/command/plugins/create_spec.rb:61: Pod::Command::Plugins::Create - should not prefix the name if already prefixed
    ./spec/command/plugins/create_spec.rb:54
    ./spec/command/plugins/create_spec.rb:7

Bacon::Error: "\e[32m\n[!] using template 'https://github.com/CocoaPods/cocoapods-plugin-template.git'\e[0m\n\e[32m\n[!] Don't forget to create a Pull Request on https://github.com/CocoaPods/cocoapods.org\n to add your plugin to the plugins.json file once it is released!\e[0m\n".include?("Creating `cocoapods-banana` plugin") failed
    ./spec/command/plugins/create_spec.rb:75: Pod::Command::Plugins::Create - should download the default template repository
    ./spec/command/plugins/create_spec.rb:66
    ./spec/command/plugins/create_spec.rb:7

Bacon::Error: "\e[32m\n[!] using template 'https://github.com/CocoaPods/cocoapods-banana-plugin-template.git'\e[0m\n\e[32m\n[!] Don't forget to create a Pull Request on https://github.com/CocoaPods/cocoapods.org\n to add your plugin to the plugins.json file once it is released!\e[0m\n".include?("Creating `cocoapods-banana` plugin") failed
    ./spec/command/plugins/create_spec.rb:86: Pod::Command::Plugins::Create - should download the passed in template repository
    ./spec/command/plugins/create_spec.rb:78
    ./spec/command/plugins/create_spec.rb:7

NameError: uninitialized constant Gem::RemoteFetcher::UnknownHostError
    ./spec/command/gem_index_cache_spec.rb:27: Pod::Command::GemIndexCache - notifies the user when getting the spec index fails
    ./spec/command/gem_index_cache_spec.rb:26
    ./spec/command/gem_index_cache_spec.rb:6

25 specifications (28 requirements), 4 failures, 7 errors

from cocoapods-plugins.

segiddins avatar segiddins commented on June 15, 2024

OK, so this failed for me on rubygems 1.6.2, but after a gem update --system to rubygems version 2.4.1, the specs all passed again.

from cocoapods-plugins.

segiddins avatar segiddins commented on June 15, 2024 
bundle exec bacon spec/command/gem_helper_spec.rb spec/command/plugins/search_spec.rb spec/command/plugins/create_spec.rb spec/command/plugins_helper_spec.rb spec/command/plugins_spec.rb spec/command/gem_index_cache_spec.rb spec/command/plugins/list_spec.rb

Pod::Command::GemHelper
  - detects if a gem is installed [FAILED]
  - detects if a specific version of a gem is installed [FAILED]
  - creates a version list that includes all versions of a single gem [FAILED]

Pod::Command::Plugins::Search
  ✓ registers itself (8 ms)
  ✓ should require a non-empty query (21 ms)
  ✓ should require a valid RegExp as query
  - should filter plugins only by name without full search [FAILED]
  - should filter plugins by name, author, description with full search [FAILED]

Pod::Command::Plugins::Create
  ✓ registers itself
  ✓ should require a name is passed in
  ✓ should require a non-empty name is passed in
  ✓ should require the name does not have spaces
Configuring cocoapods-unprefixed
user name:Samuel E. Giddins
user email:[email protected]
year:2014
  ✓ should prefix the given name if not already (1.3 s)
Configuring cocoapods-prefixed
user name:Samuel E. Giddins
user email:[email protected]
year:2014
  ✓ should not prefix the name if already prefixed (1.3 s)
  ✓ should download the default template repository
  ✓ should download the passed in template repository

Pod::Command::PluginsHelper
  ✓ downloads the json file (7 ms)
  ✓ handles empty/bad JSON (13 ms)
  ✓ notifies the user if the download fails (8 ms)

Pod::Command::Plugins
  ✓ registers itself and uses the default subcommand
  ✓ exists

Pod::Command::GemIndexCache
  ✓ notifies the user that it is downloading the spec index (3 ms)
  - notifies the user when getting the spec index fails [FAILED]

Pod::Command::Plugins::List
  ✓ registers itself
  - prints out all plugins [FAILED]

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::GemHelper - detects if a gem is installed
    ./spec/command/gem_helper_spec.rb:16
    ./spec/command/gem_helper_spec.rb:15
    ./spec/command/gem_helper_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::GemHelper - detects if a specific version of a gem is installed
    ./spec/command/gem_helper_spec.rb:21
    ./spec/command/gem_helper_spec.rb:20
    ./spec/command/gem_helper_spec.rb:6

NameError: uninitialized constant Gem::NameTuple
    ./spec/command/gem_helper_spec.rb:27: Pod::Command::GemHelper - creates a version list that includes all versions of a single gem
    ./spec/command/gem_helper_spec.rb:26
    ./spec/command/gem_helper_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::Plugins::Search - should filter plugins only by name without full search
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:128:in `plugin_title'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:75:in `print_plugin'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:52:in `run'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `each'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `run'
    ./spec/command/plugins/search_spec.rb:40
    ./spec/command/plugins/search_spec.rb:37
    ./spec/command/plugins/search_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::Plugins::Search - should filter plugins by name, author, description with full search
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:128:in `plugin_title'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:75:in `print_plugin'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:52:in `run'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `each'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/search.rb:51:in `run'
    ./spec/command/plugins/search_spec.rb:49
    ./spec/command/plugins/search_spec.rb:46
    ./spec/command/plugins/search_spec.rb:6

NameError: uninitialized constant Gem::RemoteFetcher::UnknownHostError
    ./spec/command/gem_index_cache_spec.rb:27: Pod::Command::GemIndexCache - notifies the user when getting the spec index fails
    ./spec/command/gem_index_cache_spec.rb:26
    ./spec/command/gem_index_cache_spec.rb:6

NoMethodError: undefined method `find_all_by_name' for Gem::Specification:Class
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/gem_helper.rb:43:in `gem_installed?': Pod::Command::Plugins::List - prints out all plugins
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:128:in `plugin_title'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins_helper.rb:75:in `print_plugin'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:26:in `run'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:25:in `each'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:25:in `run'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/vendor/bundle/bundler/gems/CocoaPods-576b10b9bf72/lib/cocoapods/user_interface.rb:91:in `title'
    /Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/lib/pod/command/plugins/list.rb:24:in `run'
    ./spec/command/plugins/list_spec.rb:23
    ./spec/command/plugins/list_spec.rb:21
    ./spec/command/plugins/list_spec.rb:6

25 specifications (32 requirements), 0 failures, 7 errors
rake aborted!
Command failed with status (1): [bundle exec bacon spec/command/gem_helper_...]
/Users/segiddins/Development/OpenSource/Rainforest/cocoapods-plugins/Rakefile:28
Tasks: TOP => spec
(See full trace by running task with --trace)

from cocoapods-plugins.

fabiopelosin avatar fabiopelosin commented on June 15, 2024

I think that if Specification.find_all_by_name is not available Gem.available?('somegem') can be used.

from cocoapods-plugins.

segiddins avatar segiddins commented on June 15, 2024

@fabiopelosin I'm assigning this to you, then

from cocoapods-plugins.

fabiopelosin avatar fabiopelosin commented on June 15, 2024

With 55bbd5a the plugin should be working on 1.8.7 but the is on e test which fails... also the version fetching should be tested more extensively.

from cocoapods-plugins.

kylef avatar kylef commented on June 15, 2024

@fabiopelosin @alloy Is this issue still relevant, have we officially dropped 1.8.7 yet?

from cocoapods-plugins.

alloy avatar alloy commented on June 15, 2024

@kylef @fabiopelosin Let’s do so when Yosemite is publicly released.

from cocoapods-plugins.

segiddins avatar segiddins commented on June 15, 2024

We have dropped 1.8.7 support as of CocoaPods 0.35

from cocoapods-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.