Client connection revive about wampsharp HOT 6 CLOSED

Isn't implemented yet?

from wampsharp.

Not implented yet. Note this is a WAMP client feature. You are welcome to write a pull request.

from wampsharp.

Oh, I thought it's a client feature. We're good.

from wampsharp.

@darkl I might take a look at this, shall I send a PR on the on wamp1 or 2?

from wampsharp.

Hmmm,
The WAMPv1 and WAMPv2 client implementations are different (wampv2 branch also has WAMPv1 implementation, but its WAMPv2 client is implemented differently).

The reason I never implemented this is because in the wampv1 branch the interface for IWampConnection is ISubject which is an IObservable.
Due to rx guidelines, after an IObservable has sent OnError or OnCompleted, it should never send any further messages. This makes the revive feature problematic - since after an OnError or OnCompleted, the connection will try to reconnect and then send other messages to its observers.
I've changed the interface for IWampConnection in the wampv2 branch, so now it is no longer a ISubject and we won't break rx guidelines.

So if you're willing to work on this, please work on wampv2 branch. I guess you should work on the WAMPv1 client there, since WAMPv2 client is still in work in progress.

Thanks

from wampsharp.

Implemented for WAMPv2, see #60.

from wampsharp.