What are you trying to achieve? I'm probably overlooking something

<div class="highlight highlight-source-shell notranslate position-relative overflow-auto" dir="auto"

Output messages don't make sense about codeception HOT 4 CLOSED

neuberkauf commented on June 12, 2024

Output messages don't make sense

from codeception.

Comments (4)

Naktibalda commented on June 12, 2024

This is how Codeception step works.
It converts action name to words and appends all arguments.
It looks much better when you use a module that was properly designed for Codeception:

I am on page "/about"
I click "button"
I see "some text"

I aggree that Asserts step output is ugly, but there is not much we can do short of rewriting Asserts module and/or Codeception.

assertThat is the only method that takes constraint as parameter, the output could be improved by modifying Step class to call toString -

Codeception/src/Codeception/Step.php

Lines 169 to 179 in 7d754d1

 } elseif (is_object($argument)) { 

 if ($argument instanceof FormattedOutput) { 

 $argument = $argument->getOutput(); 

 } elseif (method_exists($argument, '__toString')) { 

 $argument = (string)$argument; 

 } elseif ($argument::class == 'Facebook\WebDriver\WebDriverBy') { 

 $argument = Locator::humanReadableString($argument); 

 } else { 

 $argument = $this->getClassName($argument); 

 } 

 }

Generating step outputs from method names is one of the main Codeception ideas, I don't thing that it can be replaced with something similar to Constraint.

from codeception.

neuberkauf commented on June 12, 2024

i figured the Assert language is coming from the underlying PHPUnit. No big deal there.

Adjusting to handle Constraint objects would be fantastic. Seems like a simple thing if you'd like me to check out and submit a PR.

from codeception.

jtheuerkauf commented on June 12, 2024

$ php codecept run unit tests/unit/Codeception/StepTest.php

Codeception PHP Testing Framework v5.0.12 https://stand-with-ukraine.pp.ua
[Seed] 109444475

Unit Tests (12) ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
✔ StepTest: Multi byte text length is measured correctly(0.74s)
✔ StepTest: Single quoted string as argument(0.00s)
✔ StepTest: See uppercase text(0.00s)
✔ StepTest: Get arguments(0.15s)
✔ StepTest: Array as argument(0.00s)
✔ StepTest: No args(0.00s)
✔ StepTest: Constraint output(0.24s) * new *
✔ StepTest: Formatted output(0.02s)
✔ StepTest: See multi line string in single line(0.00s)
✔ StepTest: Am on url(0.00s)
✔ StepTest: Get html(0.00s)
✔ StepTest: Long arguments(0.02s)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 00:05.290, Memory: 12.00 MB

OK (12 tests, 24 assertions)

from codeception.

neuberkauf commented on June 12, 2024

(Sorry for posting under two accounts... This one is my work account - i forgot to switch over.)

from codeception.

Output messages don't make sense about codeception HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	} elseif (is_object($argument)) {
	if ($argument instanceof FormattedOutput) {
	$argument = $argument->getOutput();
	} elseif (method_exists($argument, '__toString')) {
	$argument = (string)$argument;
	} elseif ($argument::class == 'Facebook\WebDriver\WebDriverBy') {
	$argument = Locator::humanReadableString($argument);
	} else {
	$argument = $this->getClassName($argument);
	}
	}