Try-catch in the second test catches fail in the first test about codeception HOT 6 CLOSED

Works as expected up to version 5.0.6, but encountering issues starting from 5.0.7

from codeception.

Looks like broken in #6623

from codeception.

same for me

from codeception.

Yes, the same issue after upgrade. Could you please fix it ASAP?

from codeception.

The same issue for me, could check it pls?

from codeception.

I am having the same issue.

The following test code will fail test2 with the failure from test1

<?php

namespace Tests\Unit;

use Codeception\Test\Unit;
use PHPUnit\Framework\AssertionFailedError;
use Tests\Support\UnitTester;

class TestTest extends Unit {

	protected UnitTester $tester;

	public function test1(){
		static::fail(':-(');
	}

	public function test2(){
		$this->expectException(AssertionFailedError::class);
		$this->tester->assertFalse(true);
	}

}

Using the phpunit assertions in test2 instead of the Assert module will show the test passed as expected

I have identified the source of the failure in Codeception\Test\Test line from 172

if (method_exists($this, 'getScenario')) {
    foreach ($this->getScenario()?->getSteps() ?? [] as $step) {
        if ($step->hasFailed()) {
            $lastFailure = $result->popLastFailure();
            if ($lastFailure !== null) {
                throw $lastFailure->getFail();
            }
        }
    }
}

The line from test2 $this->tester->assertFalse(true); causes a scenario step to fail, but the test succeeds as the exception was expected.
The code from Codeception\Test\Test then sees the scenario step has failed, and then grabs the last test failure to report which is from a different test

from codeception.