Giter VIP home page Giter VIP logo

Comments (6)

maxkwallace avatar maxkwallace commented on June 6, 2024

@nwalton125 Hey! This task hasn't been updated in a few months so I just wanted to check in and see how it's going. Are you still working on this task? If not, or if I don't hear back, I will open it up for someone else to work on.

from recordexpungpdx.

nwalton125 avatar nwalton125 commented on June 6, 2024

from recordexpungpdx.

maxkwallace avatar maxkwallace commented on June 6, 2024

@nwalton125 no worries! Thanks for the reply :)

from recordexpungpdx.

NickSchimek avatar NickSchimek commented on June 6, 2024

@maxkwallace I added a temporary fix to this in another commit. It still parses the charges, but it doesn't save the results. We could probably close this issue?
It's not so important, but what I would actually like to see done is a complete re-write or refactor of the record parser so that it is easier to understand. What do you think?

from recordexpungpdx.

maxkwallace avatar maxkwallace commented on June 6, 2024

@NickSchimek sounds good, I'll close the issue.

Regarding the refactor I'd have to read the parser code myself in order to comment. I trust your judgment. There are a lot of factors that go into deciding whether a refactor makes sense but IMO the main ones are (1) whether the code is functioning well now and (2) whether or not it will need to be edited many times in the future.

from recordexpungpdx.

NickSchimek avatar NickSchimek commented on June 6, 2024

@maxkwallace yeah, I completely agree. It most likely will not have to be edited in the future, and it currently works so.... It was just something that would be nice, but is not currently necessary.

from recordexpungpdx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.