Giter VIP home page Giter VIP logo

Comments (12)

garronej avatar garronej commented on August 31, 2024 1

Done.
It's beeing released.
It's ... v1.0.0

from react-dsfr.

rtaieb avatar rtaieb commented on August 31, 2024 1

Thank you so much for this, and in fact for this whole module 🥇

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

Hi @powderham,

It's intentional since all governemental website should have the same favicon but allright, it could be a good idea to at least give an option not to include the favicon.

That being said, are you freelancing for the french public service?
I'm saying that because this design system is only meant to be used for French Governemental website...

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

I mean do what your whant, it's open source and I'm just the dev but be aware that you could get your website taken down by the french authorities if it looks too much alike a governemental website...

from react-dsfr.

powderham avatar powderham commented on August 31, 2024

Interesting, I can't see this written anywhere in the guides. Perhaps best to do so, given it's in the public domain.

I'm not freelancing for the french public service, but I think the component library is smart, and with a few tweaks would serve as a nice base for my web app.

I'll look now at opening a PR to disclude the favicons.

Are there any other french public sector assets or similar baked in that i should be aware of before using it?

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

Yes it's my bad I should have included warning everywhere before promoting this to social media.
I'd say be carefull when using assets.

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

Hi, I found the GGU of the DS: https://www.systeme-de-design.gouv.fr/cgu/

from react-dsfr.

rtaieb avatar rtaieb commented on August 31, 2024

Hi @garronej ,
Could this issue be reopened ?
It would be nice to be able to opt out of the DSFR favicon when using NextJS app dir.
(As @powderham , I could'n find a way to do it).

Thanks :)

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

Hi @rtaieb,
The issue here is that the Marianne Favicon is a requirement from the DSFR team it's not something that you are supposed to customize.
I guess we could argue that you might want to programatically edit the favicon to show notifications for example.
Could you explain your usecase just so I can motivate why I'm enabling the favicon to be customized.

Thanks

from react-dsfr.

rtaieb avatar rtaieb commented on August 31, 2024

Well I'm working for the ADEME, which is associated to the Ministère de la Transition Ecologique.
From what we've been told by the ADEME lead desinger, the ADEME can take the DSFR as a basis, and then tweak it depending on the product / design needs.
That's what I've been doing so far, but couldn't override the favicon set by DsfrHead component...

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

Ok, I'll add an option

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

You're welcome ☺️

from react-dsfr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.