Comments (9)
Should be linked to #77 PR.
from react-dsfr.
Following the implementation of the partners
section in the footer component, I get a live result like this:
And I wonder... 🤔
- When there are 2 logos only, won't it be better to put them both together on the left or the right side?
And in this case I guess that main
should become optional as well because only sub
is supposed to be a list ?
Lines 90 to 93 in 2c2022a
- The
target="_blank"
added to the links displays an icon next to the logos. Should we keep it like this?
from react-dsfr.
You're probably not running the latest version.
I patched your PR, check it out: #77 (comment)
from react-dsfr.
For the case where ther's only two logo, I agree that it's a bit odd looking but react-dsfr has no say on this kind of things.
It's an integration library that must align 100% with the vanilla implementation @gouvfr/dsfr.
https://main--ds-gouv.netlify.app/example/component/footer/
from react-dsfr.
What you can do is use theclasses.partnersLogos
props of the
from react-dsfr.
It's an integration library that must align 100% with the vanilla implementation @gouvfr/dsfr.
About that I asked the DSFR team how the case with 2 partners icons only should be handled.
Bonjour Gary,
Vous pouvez voir les exemples ici https://main--ds-gouv.netlify.app/example/component/footer/
Avec 2 logo partenaires, au choix, vous pouvez mettre un principal à gauche et un secondaire à droite ou bien les 2 en secondaire à droite.
Bonne journée
Bertrand pour l'équipe DSFR
My interpretation here is that main
should become optional as sub
is... but at least one of them must be declared.
from react-dsfr.
but at least one of them must be declared
This is not easy to type, maybe it's best to have the first of the list being the main what do you think?
from react-dsfr.
Here is my proposal to "solve" the issue: #81
from react-dsfr.
Sounds like job is done here. Closing the issue.
from react-dsfr.
Related Issues (20)
- [Footer] Add custom links beside accessibility & terms HOT 1
- Change french licence statement HOT 3
- MUI DataGrid TrustedHTML problem HOT 2
- Select id native props HOT 1
- Select id native props 2 HOT 2
- Problème de sémantique HTML dans le composant Header HOT 11
- Problème de sémantique HTML dans le composant Footer HOT 1
- Composant header avec un seul élément dans la liste quickAccessItems HOT 4
- Working on Follow component HOT 4
- Add Segmented control component
- Add Range component
- [generatedFromCss] classes manquantes HOT 4
- Update README to clarify who is the maintainer HOT 2
- Update consentManagement stories HOT 3
- quickAccessItems in Header component HOT 2
- `only-include-used-icons` may look into the wrong folder HOT 7
- Duplicate ID in Consent management modal HOT 1
- Search Bar : Demande d'ajout de fonctionnalités HOT 1
- dsfr-charts HOT 5
- open Modal error HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-dsfr.