Add partners to footer component about react-dsfr HOT 9 CLOSED

Should be linked to #77 PR.

from react-dsfr.

Following the implementation of the partners section in the footer component, I get a live result like this:

And I wonder... 🤔

1. When there are 2 logos only, won't it be better to put them both together on the left or the right side?

And in this case I guess that main should become optional as well because only sub is supposed to be a list ?

2. The target="_blank" added to the links displays an icon next to the logos. Should we keep it like this?
   

from react-dsfr.

You're probably not running the latest version.
I patched your PR, check it out: #77 (comment)

from react-dsfr.

For the case where ther's only two logo, I agree that it's a bit odd looking but react-dsfr has no say on this kind of things.
It's an integration library that must align 100% with the vanilla implementation @gouvfr/dsfr.
https://main--ds-gouv.netlify.app/example/component/footer/

from react-dsfr.

What you can do is use theclasses.partnersLogos props of the

from react-dsfr.

It's an integration library that must align 100% with the vanilla implementation @gouvfr/dsfr.

About that I asked the DSFR team how the case with 2 partners icons only should be handled.

Bonjour Gary,

Vous pouvez voir les exemples ici https://main--ds-gouv.netlify.app/example/component/footer/

Avec 2 logo partenaires, au choix, vous pouvez mettre un principal à gauche et un secondaire à droite ou bien les 2 en secondaire à droite.

Bonne journée

Bertrand pour l'équipe DSFR

My interpretation here is that main should become optional as sub is... but at least one of them must be declared.

from react-dsfr.

but at least one of them must be declared

This is not easy to type, maybe it's best to have the first of the list being the main what do you think?

from react-dsfr.

Here is my proposal to "solve" the issue: #81

from react-dsfr.

Sounds like job is done here. Closing the issue.

from react-dsfr.