Comments (4)
Right now it's not in production, we only start the project last month. But when it will be available, I will send you the url
from react-dsfr.
Hey @damienguezou,
Your contribution will be very much appreciated yes and it does belong in this indeed.
We should put all the functionall block in a subdirectory like import { PasswordInput } from "@codegouvfr/react-dsfr/blocks/PasswordInput
.
But don't worry about it, I'll handle lit.
Just make sur to design your component in a way that is customisable enough. (Three level of hint: info, warn, errror).
Taking charge of giving a capslock visual feedback is a good idea, it's generic, no need to delegate this responsability to our users.
The toogle hide/show is also a big plus 👍🏻
Currently pepoles are usin the MUI imput component just for this, it would be very nice to have it.
I'll give you access to the repo so that you can create a branch and open a PR.
(If it's a PR from a branch we can easyly create a release candidate).
https://github.com/codegouvfr/react-dsfr/invitations
As a first time contributor, have a look at this guide: https://github.com/codegouvfr/react-dsfr/blob/main/CONTRIBUTING.md It will save you a lot of time down the drain.
Can you give me the link of the repo you are working on?
from react-dsfr.
Ok fine, I will try to take inspiration the components existing already.
Sure I will take a more deeper look on the contribution guide.
Sorry I can't give you the link of the repo, it's currently a private repository.
from react-dsfr.
Thanks, sounds great 💯
it's currently a private repository
Public money => public code !
Can you give me the url of the deployment? It's just to keep track of the project that are levraging react-dsfr.
from react-dsfr.
Related Issues (20)
- Add Range component
- [generatedFromCss] classes manquantes HOT 4
- Update README to clarify who is the maintainer HOT 2
- Update consentManagement stories HOT 3
- quickAccessItems in Header component HOT 2
- `only-include-used-icons` may look into the wrong folder HOT 7
- Duplicate ID in Consent management modal HOT 1
- Search Bar : Demande d'ajout de fonctionnalités HOT 1
- dsfr-charts HOT 5
- open Modal error HOT 7
- Scoped CSS HOT 5
- Page storybook Range ne charge pas HOT 4
- Problème d'hydratation React du composant Card HOT 1
- Component Range : la props "step" fait crasher le navigateur sur le storybook et dans l'app HOT 11
- Footer : sans partenaire principal, les partenaires secondaires devraient être alignés à gauche HOT 4
- SelectNext: régression placeholder toujours sélectionnable HOT 1
- Accordion: La props 'expanded' ne controlle pas réellement l'ouverture / fermeture HOT 1
- Component Range : BUG avec l'option double HOT 4
- MainNavigation: Ajouter la possibilité d'un sous-menu ? HOT 2
- Composant MainNavigation - Mega menu - Bouton Fermer HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-dsfr.