Giter VIP home page Giter VIP logo

Comments (4)

damienguezou avatar damienguezou commented on August 31, 2024 1

Right now it's not in production, we only start the project last month. But when it will be available, I will send you the url

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

Hey @damienguezou,

Your contribution will be very much appreciated yes and it does belong in this indeed.

We should put all the functionall block in a subdirectory like import { PasswordInput } from "@codegouvfr/react-dsfr/blocks/PasswordInput.
But don't worry about it, I'll handle lit.
Just make sur to design your component in a way that is customisable enough. (Three level of hint: info, warn, errror).
Taking charge of giving a capslock visual feedback is a good idea, it's generic, no need to delegate this responsability to our users.
The toogle hide/show is also a big plus 👍🏻
Currently pepoles are usin the MUI imput component just for this, it would be very nice to have it.

I'll give you access to the repo so that you can create a branch and open a PR.
(If it's a PR from a branch we can easyly create a release candidate).

https://github.com/codegouvfr/react-dsfr/invitations

As a first time contributor, have a look at this guide: https://github.com/codegouvfr/react-dsfr/blob/main/CONTRIBUTING.md It will save you a lot of time down the drain.

Can you give me the link of the repo you are working on?

from react-dsfr.

damienguezou avatar damienguezou commented on August 31, 2024

Ok fine, I will try to take inspiration the components existing already.

Sure I will take a more deeper look on the contribution guide.

Sorry I can't give you the link of the repo, it's currently a private repository.

from react-dsfr.

garronej avatar garronej commented on August 31, 2024

Thanks, sounds great 💯

it's currently a private repository

Public money => public code !
Can you give me the url of the deployment? It's just to keep track of the project that are levraging react-dsfr.

from react-dsfr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.