Comments (2)
Since the v3.0.0 branch, I've reconsidered this and I don't think it wise to pass the request instance as the request options to the request constructor. There is too much potential for side effects but re-initializing the request in the form of a redirect is maybe still doable. I'm just saying we should be explicit about what we want to pass to the request constructor.
from cloudscraper.
Since we know we're likely to make serial requests to the same server after the first challenge, the forever request option might be a good default option for subsequent requests. It would enable keep-alive
by default and thus increase the probability of connection reuse if the server doesn't explicitly close. If using this option, I think the agent should be reused as well. I'm not sure if sockets are exclusive to an agent but if they are, it justifies reusing the agent.
However, the potential minor performance gain from this doesn't seem to justify adding it at all. This is better left as an exercise for the library user since it can be accomplished by passing options to cloudscraper that request
supports. If Cloudflare was ever to rely on keep-alive
connection behavior as part of some heuristic, we could revisit this. I'm closing for now. Feel free to open this back up if I missed something or some header information needs to be reused.
from cloudscraper.
Related Issues (20)
- CloudflareError: Cloudflare challenge loop HOT 11
- Always get reCaptcha and unable to solve it HOT 5
- ParserError on opening any cloudflare website HOT 1
- Replace request with node-fetch HOT 8
- CloudflareError: Cloudflare challenge loop error in latest version HOT 3
- Solving reCaptcha creates recursive loop with POST
- Cloudflare error: 1020, access Denied HOT 2
- function onCaptcha looping HOT 5
- Issue challengeId (jschl_vc) extraction failed
- Cloudflare Error 4 (challenge loop)
- ECONNRESET HOT 1
- Challenge form extraction failed
- Cloudflare detects non-browser requests, and returns captcha. HOT 4
- Can not pass IP ban
- Challenge form extraction failed on https://www.nakedcph.com/en/auth/view?op=register
- hCaptcha HOT 3
- setTimeout callback extraction failed HOT 2
- New CloudFlare Method detects if you're running bypass on Linux or Windows machine
- 1020, Access Denied (Custom Firewall Rules) HOT 30
- deprecated request package since Feb 11th 2020 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudscraper.