Re-use request about cloudscraper HOT 2 CLOSED

Since the v3.0.0 branch, I've reconsidered this and I don't think it wise to pass the request instance as the request options to the request constructor. There is too much potential for side effects but re-initializing the request in the form of a redirect is maybe still doable. I'm just saying we should be explicit about what we want to pass to the request constructor.

from cloudscraper.

Since we know we're likely to make serial requests to the same server after the first challenge, the forever request option might be a good default option for subsequent requests. It would enable keep-aliveby default and thus increase the probability of connection reuse if the server doesn't explicitly close. If using this option, I think the agent should be reused as well. I'm not sure if sockets are exclusive to an agent but if they are, it justifies reusing the agent.

However, the potential minor performance gain from this doesn't seem to justify adding it at all. This is better left as an exercise for the library user since it can be accomplished by passing options to cloudscraper that request supports. If Cloudflare was ever to rely on keep-alive connection behavior as part of some heuristic, we could revisit this. I'm closing for now. Feel free to open this back up if I missed something or some header information needs to be reused.

from cloudscraper.