Giter VIP home page Giter VIP logo

Comments (11)

mikehaertl avatar mikehaertl commented on May 27, 2024

@jafaripur Just supplied a fix. Can you help testing please?

from yii2-localeurls.

jafaripur avatar jafaripur commented on May 27, 2024

@mikehaertl Yes, It's OK. Just a another issue when entered the language in url doesn't exists in configuration again same error occured.
Like this: localhost:8080/test/frontend/web/fr redirect to:
http://localhost:8080/test/frontend/web//en/en/en/en/en/en/en/en/en/en/en/en/en/en/en/en/en/en/en/enfr

'localeUrls' => [
'class' => 'codemix\localeurls\LocaleUrls',
'languages' => ['en', 'tr']
],

And this generated url for controller:
test/frontend/web/enuser/signup.html
language and controller combined and doesn't separated. In the Normal this created with this method:
http://localhost:8080/test/frontend/web/user/signup.html

from yii2-localeurls.

mikehaertl avatar mikehaertl commented on May 27, 2024

@jafaripur Can you please try again now?

from yii2-localeurls.

jafaripur avatar jafaripur commented on May 27, 2024

@mikehaertl some of the problem fixed but when a language doesn't exist redirect to this url:
http://localhost:8080/test/frontend/web/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa/fa

fa doesn't add to configuration. I think a fallback option must to add in configuration to set by default if a language doesn't exists.
Also this option doesn't work:
'languages' => [
'en',
'fa' => 'fa-IR',
]
I think this must to load url with this address but getting error:
http://localhost:8080/test/frontend/web/fa

from yii2-localeurls.

mikehaertl avatar mikehaertl commented on May 27, 2024

@jafaripur Have you really tested again with the latest code? I couldn't reproduce both issues anymore. If you think, both still exist, then please add another comment.

I'm not sure, if I understand what you mean with this fallback feature. But if you want to discuss it, please open another issue for it.

from yii2-localeurls.

jafaripur avatar jafaripur commented on May 27, 2024

@mikehaertl Issue exist if a language is not defined in configuration!
Another this is not work:
'languages' => [
'en',
'fa' => 'fa-IR',
]
In document this is mentioned for map "fa" to "fa-IR" and locale with fa is same as fa-IR

from yii2-localeurls.

mikehaertl avatar mikehaertl commented on May 27, 2024

Are you really sure, that you use the latest files? Please download them manually from here:

https://raw.githubusercontent.com/codemix/yii2-localeurls/master/LocaleUrls.php
https://raw.githubusercontent.com/codemix/yii2-localeurls/master/UrlManager.php

The issues you describe should be fixed with the commits above. So if your application runs under some directory (basePath not empty):

  • No more endless redirects
  • If you use a language that is not defined, you should see a 404
  • Aliases like 'fa' => 'fa-IR' work

from yii2-localeurls.

jafaripur avatar jafaripur commented on May 27, 2024

Yes, It replaced and now work as well, but aliasing doesn't work when locale alias set to 'fa' this must to refer to 'fa-IR' locale but try to loading 'fa' language files from the message which doesn't exist.

from yii2-localeurls.

mikehaertl avatar mikehaertl commented on May 27, 2024

This should also be fixed now. Can you please try again?

from yii2-localeurls.

jafaripur avatar jafaripur commented on May 27, 2024

Very good, Thank you!

from yii2-localeurls.

mikehaertl avatar mikehaertl commented on May 27, 2024

Great! Thanks for your help.

from yii2-localeurls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.