Giter VIP home page Giter VIP logo

Comments (6)

Tedyhere avatar Tedyhere commented on August 16, 2024 1

Thanks for the quick response, I ended up fixing the script errors, but yeah having it spit out the errored line would be preferrable. Thanks for the quick response. Love the mod, as well as your Artisan Tables one

from advancedmortars.

codetaylor avatar codetaylor commented on August 16, 2024

I'm working on adding some checks to prevent the NPE you described. I am unable to fully replicate your problem (with the exact script you provided) because I don't have Silent's Gems or your custom ContentTweaker content.

In the meantime, I do notice that in some places you have <contenttweaker:white:dye> and others <contenttweaker:white_dye>. That might be the source of your problem.

CraftTweaker probably errors on parsing the <contenttweaker:white:dye> and returns a null.

I'll see if I can't replicate the behavior using a bracket handler like that.

Did this error happen on a server?

Does running /ct syntax show any errors?

from advancedmortars.

codetaylor avatar codetaylor commented on August 16, 2024

My theory was correct and I was able to replicate the problem you've described.

Using this script:

import mods.advancedmortars.Mortar;
import crafttweaker.item.IItemStack;

Mortar.addRecipe(["wood", "stone"], <minecraft:dye:2>, 10, [<minecraft:dye:white>]);

Crash:
https://gist.github.com/codetaylor/e64362a829e4c65b2c578b955e9c72f9

from advancedmortars.

codetaylor avatar codetaylor commented on August 16, 2024

Ok, this is better.

It will now fully load and display this in the console:
image

As well as display this in the crafttweaker.log file:

[INITIALIZATION][CLIENT][INFO] CraftTweaker: Building registry
[INITIALIZATION][CLIENT][INFO] CraftTweaker: Successfully built item registry
[INITIALIZATION][CLIENT][INFO] Loading scripts
[INITIALIZATION][CLIENT][INFO] [crafttweaker | SIDE_CLIENT]: Loading Script: {[0:crafttweaker]: mortar.zs}
[INITIALIZATION][CLIENT][ERROR] mortar.zs:5: Could not resolve <minecraft : dye : white>
[AVAILABLE][CLIENT][INFO] Altering mods.advancedmortars.Mortar Recipe(s) for <minecraft:dye:2>
[AVAILABLE][CLIENT][ERROR] Unknown input type: null
[SERVER_STARTED][CLIENT][INFO] Fixed the RecipeBook

from advancedmortars.

codetaylor avatar codetaylor commented on August 16, 2024

Fixed in 1.6.15

from advancedmortars.

codetaylor avatar codetaylor commented on August 16, 2024

Build 1.6.15 submitted to CurseForge.

from advancedmortars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.