Comments (4)
A simpler alternative would be to introduce a toggle to show/hide the titles.
And let people just work around the fixed placement.
Including some unique id/class into the DOM would still be helpful for CSS fine-tuning however.
from pageflow-linkmap-page.
I see your point, but I must admit I'm a bit scared of adding this additional complexity. The main problem that I see is that the linkmap page uses the page scroller to achieve its panorama effect. I therefore see two possibilities:
- Place the titles inside the scroller and have them move out of viewport when scrolling
- Place the titles outside the scroller to display them above the moving panorama
Option 1. has the downside that there is no easy way to constrain the size of the titles to fit into the viewport. Having to pan the panorama to read the whole title will sure seem broken,
With option 2. there is no way of handling overflowing titles on small viewports. Moreover, on older IEs, there is no pointer-events
, so we would need to find a way to let the user interact with the panorama through the titles.
Finally, I'm quite opposed to the idea of leaving such difficult and brittle decisions to the theme author. We went through the work intensive process of migrating all our themes to use the configurable default theme and I'd regret having to move in another direction again. Otherwise we'll have no way of changing the linkmap page in the future without breaking custom themes again.
So if we find a way to make this happen, I'd open for it, but from my point of view the solution would have to live in the page types code base - even if it is disabled by default.
from pageflow-linkmap-page.
I propose I fork the page type first and work out the kinks in our productions. Afterwards we can apply the learnings upstream, or we can keep maintaining the forked version for ourselves.
from pageflow-linkmap-page.
Ok. Let me know if you need any help/pointers.
from pageflow-linkmap-page.
Related Issues (9)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pageflow-linkmap-page.