Implementation of filters about find-a-mentor HOT 27 CLOSED

fyi: I'll find time for this by the end of next week

from find-a-mentor.

since I started working on this with my open issue I am happy to take this one @moshfeu @emmawedekind @manpenaloza

from find-a-mentor.

Interesting idea!
@emmawedekind.

from find-a-mentor.

Love the idea! I'll incorporate it into the re-design and leave the logic up to you if you're still interested :)

from find-a-mentor.

Ok! Thanks for letting us know.
If we will find someone (or one of us will take this) I'll let you know.

from find-a-mentor.

@emmawedekind saw the designs, started on it this morning hope to have some stuff committed shortly.

from find-a-mentor.

sure! Looking forward to it.

from find-a-mentor.

@emmawedekind do we know how it should look with the new UI? And mobile?

from find-a-mentor.

Sure I can update the design!

from find-a-mentor.

thx for the briefing!

@moshfeu @emmawedekind I'll start implementing based on the current master branch, ok?

from find-a-mentor.

Wait. We have some "in progress" relates tasks - #136 and #27.
I think we should wait for them. @emmawedekind ?

from find-a-mentor.

thx for the info. jap, they're very closely related and developing this issue in parallel will very likely lead to conflicts and bugs. also as it depends on how 'tag is clicked/toggled' state will be handled in those other issues.

so I'll be there if you need me and if this is going to be continued.

from find-a-mentor.

Let's complete this first, then #136 and #27 can follow!

from find-a-mentor.

ok, thx for info. will be busy until the end of this week and will start with this next week. hope that's ok for you.

I'll probably go with what @moshfeu mentioned in #136 regarding the usage of https://react-select.com. More on that when I'll start WIP pr.

from find-a-mentor.

Thanks!
You can create WIP PR (Just regular PR with WIP in its title so we could track the progress but will know to not merge it yet.)

from find-a-mentor.

@moshfeu today got some urgent/important todos that will cover my upcoming dev-weeks. so either i have to postpone this a bit in case it does not hurry (can start in about 3 weeks from now on) or someone else wants to give it a try?

from find-a-mentor.

FYI I have added acceptance criteria to this issue!

from find-a-mentor.

Additionally, we have new designs, so please hold off on development until I've added those in. I should have them updated by tonight!

from find-a-mentor.

@brockmdavis Sure!
Don't forget to wait for the new design.

from find-a-mentor.

Just put it here: https://react-select.com/home, https://github.com/jedwatson/react-select

from find-a-mentor.

@brockmdavis I've added the new design & acceptance criteria in the issue description. I haven't finished the mobile layout yet but will get that as soon as possible.

from find-a-mentor.

Additionally, with the implementation of #193, we need to make sure that if a user clicks the tag on the profile card that it updates the list below the search bar.

from find-a-mentor.

Let's wait for it. Ok? I'll review #193 later today.

from find-a-mentor.

Don't you want to wait for #193?

from find-a-mentor.

#193 is now merged! :)

from find-a-mentor.

@brockmdavis Any update? Some PRs merged since then so make to to fetch from the master.
Thanks!

from find-a-mentor.

Since no response, I'll close this and create a new one for a cleaner view.
Thanks

from find-a-mentor.