Giter VIP home page Giter VIP logo

Comments (4)

ScottWales avatar ScottWales commented on July 21, 2024

tos is not in the latest directory, only in v20120213. There are also more variables only in v20110518

from clef.

paolap avatar paolap commented on July 21, 2024

Hi Scott,

I'm not sure what's going here, we knew about this issue already, in fact I forgot but meant to say to NCI that they aren't linking all the latest versions correctly.
At the time we decided to pass whatever we found unchanged
From code.py in master:

def fix_path(path):
'''Get path from query results and replace al33 output1/2 dirs to combined
and rr3 ACCESS "/files/" path to "/latest/"
'''
if '/al33/replicas/CMIP5/output' in path:
return re.sub(r'replicas/CMIP5/output[12]?/','replicas/CMIP5/combined/',path)
elif '/al33/replicas/CMIP5/unsolicited' in path:
return path.replace('unsolicited','combined')
elif '/rr3/publications/CMIP5/output1/CSIRO-BOM' in path:
dirs=path.split("/")
var = dirs[-2].split("_")[0]
return "/".join(dirs[0:-3]+['latest',var,dirs[-1]])
else:
return path

We're not doing anything with the CSIRO-QCCCE data it should just return the path as it is.
It is also covered in the tests, although I realised now that I made a mistake in there, double p in pubblications:

def test_fix_path():
...
dir2 = '/g/data/rr3/pubblications/CMIP5/output1/CSIRO-QCCCE/more/files/tas_20110518/'
...

assert fix_path(dir2) == '/g/data/rr3/pubblications/CMIP5/output1/CSIRO-QCCCE/more/files/tas_20110518/'

....
So this test would pass regardless I wonder what the DB is returning.
I'll make more checks tomorrow

from clef.

paolap avatar paolap commented on July 21, 2024

Somehow something I did recently in my env on the VDI fixes this, it doesn't happen for me as along as I don't exclude my local env
Still apart from fixing the test I didn't do anything different, or at least not directly in regard to this.

from clef.

paolap avatar paolap commented on July 21, 2024

This should be solved by changing the filters in esgf.py branch localfix

from clef.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.