Comments (1)
nikulis
commented on June 8, 2024
I agree that the authenticated client should not override this.
A blame reveals that the code was inserted with a comment describing it as a "temp override" in faece04 as part of coinbase/coinbase-exchange-node#35 (no description provided).
It was then used in bf6c2a4 to add support for OrderbookSync to use an existing authenticated client as part of coinbase/coinbase-exchange-node#37 (no description provided).
I'm not sure as to the rationale of why these changes were introduced.
More recently, #37, which added support for multiple order books (specifically 2fd3464), seems to have taken a new approach by memoizing PublicClients for each requested book type, which seems like a better way to go imho.
Tagging relevant committers who may have some more insight:
@cilphex, @maxim-s, @fb55
from coinbase-pro-node.
Related Issues (20)
- Charging? HOT 2
- Abnormal prices for EOSUSD market HOT 1
- Property 'getPaymentMethods' does not exist on type 'AuthenticatedClient' HOT 1
- Orderbook sync has invalid state with crossed orders. HOT 1
- publicClient.getTicker not working in Safari HOT 1
- User Channel Not Authenticating HOT 4
- Authenticated websocket fails due to timestamp serialization HOT 2
- specifying size when buying HOT 1
- Feature Request: Add Webhook Notifications to Coinbase Pro HOT 1
- Out of sync websocket order books HOT 1
- pageArgs Not Consistent With Header Response HOT 4
- How to buy a maximum with a euro amount? HOT 2
- placeOrder throws Internal server error HOT 2
- Does this library work with Coinbase Prime HOT 2
- New release HOT 1
- Invalid Signature HOT 1
- cancelOrders returning wrong data HOT 2
- withdrawCrypto funds getting stuck HOT 1
- [Q] Whats the difference between authedClient.placeOrder and authedClient.sell HOT 2
- Historic Data seems funky HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coinbase-pro-node.