Github Action Integration about salus HOT 12 CLOSED

Hey @nishils. No problem, I'll work on this soon.

from salus.

Knocked out a first draft today! It depends on the custom_info hash feature in 2.6.3.

The major feature remaining is to add a comment to PRs with a summary of the results.

from salus.

This is awesome! It just recently got added to my backlog to work on something like this!! I'm excited to see that PR come in

from salus.

Github seems to require Actions to live in their own repo.

Wasn't sure how to brand this due to the integration with securedevelopment.com, the UI we're building around Salus, so I just called it Federacy Salus Security Scan.

https://github.com/marketplace/actions/federacy-salus-security-scan
https://github.com/federacy/scan-action

from salus.

Hey @nishils, any thoughts on the branding? My goal is to not downplay Coinbase as the author of Salus, while clarifying that you're not responsible for the Github Action or SecureDevelopment. This also provides a place to tie in documentation specific to Federacy/SecureDevelopment.

Another option is to release two Github Actions:

• one that is branded Coinbase Salus and has no additional documentation/reference to SecureDevelopment
• one that is maybe branded Federacy/SecureDevelopment Scans (with or without the Salus reference) and includes documentation

from salus.

Thanks for the ping! I was on vacation and missed this in my notifications.

I think if you mention it in your description like Salus from Coinbase, then that would be helpful.

As long as the word Salus is around and links back to this repo, then I think that is sufficient. Thanks for considering our side of it!

from salus.

Sounds good! Will make these changes and release soon.

from salus.

Okay, updated the copy to make it more clear. Just let me know if you'd like me to add some documentation to the salus repo, otherwise we can close this issue!

from salus.

Sorry for the delay on this. Can we add docs to this repo on how to get the github action configured?

from salus.

How does that look @nishils?

from salus.

looks great @jsulinski , thanks for making this! Closing the ticket now that it's resolved.

fyi, getting a bad gateway error when trying to sign up on https://www.securedevelopment.com/sign-up

from salus.

Should be fixed now. Thanks for letting me know!

from salus.