Comments (12)
Hey @nishils. No problem, I'll work on this soon.
from salus.
Knocked out a first draft today! It depends on the custom_info hash feature in 2.6.3.
The major feature remaining is to add a comment to PRs with a summary of the results.
from salus.
This is awesome! It just recently got added to my backlog to work on something like this!! I'm excited to see that PR come in
from salus.
Github seems to require Actions to live in their own repo.
Wasn't sure how to brand this due to the integration with securedevelopment.com, the UI we're building around Salus, so I just called it Federacy Salus Security Scan.
https://github.com/marketplace/actions/federacy-salus-security-scan
https://github.com/federacy/scan-action
from salus.
Hey @nishils, any thoughts on the branding? My goal is to not downplay Coinbase as the author of Salus, while clarifying that you're not responsible for the Github Action or SecureDevelopment. This also provides a place to tie in documentation specific to Federacy/SecureDevelopment.
Another option is to release two Github Actions:
- one that is branded Coinbase Salus and has no additional documentation/reference to SecureDevelopment
- one that is maybe branded Federacy/SecureDevelopment Scans (with or without the Salus reference) and includes documentation
from salus.
Thanks for the ping! I was on vacation and missed this in my notifications.
I think if you mention it in your description like Salus from Coinbase
, then that would be helpful.
As long as the word Salus is around and links back to this repo, then I think that is sufficient. Thanks for considering our side of it!
from salus.
Sounds good! Will make these changes and release soon.
from salus.
Okay, updated the copy to make it more clear. Just let me know if you'd like me to add some documentation to the salus repo, otherwise we can close this issue!
from salus.
Sorry for the delay on this. Can we add docs to this repo on how to get the github action configured?
from salus.
How does that look @nishils?
from salus.
looks great @jsulinski , thanks for making this! Closing the ticket now that it's resolved.
fyi, getting a bad gateway error when trying to sign up on https://www.securedevelopment.com/sign-up
from salus.
Should be fixed now. Thanks for letting me know!
from salus.
Related Issues (20)
- Semgrep patterns failing on 2.10.1 HOT 8
- Add support for Rust security scanning HOT 2
- add find-sec-bugs scanner
- SARIF support HOT 12
- Salus exception config not working with Circle CI HOT 4
- How to export dependencies(all) as part of the report? HOT 2
- Update NPMAudit version HOT 12
- Purpose of `safe_local_report_path`? HOT 2
- Error with Default Configs in Orb federacy/[email protected] HOT 2
- Dead Link on Salus Logo in repo's README.md
- Add pnpm audit support HOT 1
- ClairScanner Question HOT 1
- scan erros if package-lock.json is present when active_scanners: all HOT 1
- . HOT 1
- Regex used for project name validation having unexpected effect
- Add Support for Sobelow (Elixir) HOT 3
- GitHub Action example configuration fails because `cargo-audit` not found HOT 1
- Unreviewed commit on master! HOT 1
- Version 3.2.6 (9/29/2023) not latest
- Hi im new hier. My Name is Mateusz HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from salus.