Giter VIP home page Giter VIP logo

Comments (4)

colinmarc avatar colinmarc commented on July 28, 2024

Hi @gyustorm, sorry for the delay responding.

I'm not sure I completely understand your bug report - can you make a PR with a test case that panics?

from hdfs.

yugan95 avatar yugan95 commented on July 28, 2024

Hi @colinmarc Your hdfs.FileReader has only one blockReader, the FileReader implements os.File.ReadAt, so if i launch goroutines to read different ranges of the same file from hadoop for speeding up, then it will come to thread unsafe problem.

type FileReader struct {
    client *Client
    name   string
    info   os.FileInfo

    blocks      []*hdfs.LocatedBlockProto
    blockReader *rpc.BlockReader
    offset      int64

    readdirLast string

    closed bool
}

from hdfs.

colinmarc avatar colinmarc commented on July 28, 2024

Ah, I understand. I don't make any guarantees about the thread safety of FileReaders, but maybe I should. Does it work if you try to have multiple FileReaders instead of just accessing the same one concurrently?

from hdfs.

yugan95 avatar yugan95 commented on July 28, 2024

Hmm, maybe it works. Thanks for your time.

from hdfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.