RelatedItemsFieldWidget/RelationList: TypeError when I try to save about collective.z3cform.datagridfield HOT 7 CLOSED

Confirmed

from collective.z3cform.datagridfield.

Preliminary investigation of the traceback:

  Module collective.z3cform.datagridfield.datagridfield, line 283, in value
  Module plone.app.z3cform.converters, line 361, in toWidgetValue
  Module plone.app.z3cform.converters, line 362, in <listcomp>

plone.app.z3cform.converters

value is a UUID (as string). Expected: list of UUIDs
So the list comprehension iterates over the single chars of the UUID which explains the adapation error for single chars of the UUID.

As a workaround, I tried to converted value into [value].
With this workaround, the IUUID lookup fails for a correct (existing UUID).
I verified that by searching for the portal_catalog by the given UUID.

So obviously, a list of UUIDs get converted somewhere in the stack to a string (or even the UI sends improper data).

from collective.z3cform.datagridfield.

A modified version of the converter seems to work for us and possibly resolves the problem

    def toWidgetValue(self, value):
        """Converts from field value to widget.

        :param value: List of catalog brains.
        :type value: list

        :returns: List of of UID separated by separator defined on widget.
        :rtype: string
        """
        if not value:
            return self.field.missing_value
        separator = getattr(self.widget, "separator", ";")
        if IRelationList.providedBy(self.field):
            if isinstance(value, str):
                value = [value]
                return separator.join(v for v in value if v)
            else:
                return separator.join([IUUID(o) for o in value if o])
        else:
            return separator.join(v for v in value if v)

from collective.z3cform.datagridfield.

Confirmed. I've made a PR here #142 ... turns out, that the context binding on the IChoice columns was wrong ... with this fix it works for me.

from collective.z3cform.datagridfield.

One more update here #150
I've fixed the DictRowConverter to correctly convert the columns to their schema field/widget values. This fixes several issues for me when using Choice fields in the DictRow schema.

from collective.z3cform.datagridfield.

@petschki I can confirm that your PR fixes the issue where the relation field is not working correctly 👍

from collective.z3cform.datagridfield.

Fixed by #150 👍

from collective.z3cform.datagridfield.