Code-generate .zipMap functions to support Applicative macro about mill HOT 8 CLOSED

I started working on this, my patches are here - https://github.com/duncanmak/mill/tree/generate-zipmap

from mill.

@duncanmak Looks pretty good!

But how about instead of actually generating source files (which is kinda messy?), just print out the lines needed to go into the file and paste them in by-hand?

...Because I'm thinking this is a job you don't normally to very often; maybe it's a one-time-job. Just generate the code necessary, paste it in there, and call it a day.

But of course keep the code for generating the code around; with unit tests! (for risk-free refactoring in the future)

e.g. something like this:

assert(generateZipMap(2) == """def zipMap[A, B, Z](a: A, b: B, z: Z) = .......""")

Opinions? @lihaoyi ?

from mill.

from mill.

Okay - I did a bit more work tonight and now I have code-gen for mill.define.Applicative, mill.define.Target and the test ApplicativeTests.

I tested it by running the generate.sc scripts that generate FooGenerated.scala files, and compiling it using sbt core/test. It's all compiling and the tests pass.

The next step is to patch build.sbt and build.sc to run these generate.sc files prior to actually compiling the sources.

from mill.

@duncanmak any updates on this one?

from mill.

Hey @lihaoyi, I added the code generation into build.sc just now and now it runs as part of the mill build. The commit is here - https://github.com/duncanmak/mill/commit/1b27a0b2e56ceccaaffa4b3c49d4b8aa14aab6b6

The SBT part felt really above my head, so I'd need more direction for how best to integrate the code generation into build.sbt.

from mill.

I submitted #81 which is my first completed attempt of implementing this issue.

from mill.

@lihaoyi merged #81 so I'm closing this.

from mill.