Giter VIP home page Giter VIP logo

Comments (2)

dcoufal avatar dcoufal commented on May 27, 2024

I'm not sure.

We have two opposing concerns.

(1) We'd like all users to be able to create custom ValidationIssues for their custom HLS tags. So, having a string is useful for that.
(2) We'd like to be able to id specific validation issues in code. An enum is best for that.

I wonder if we'd be better off with a IssueDescription protocol instead? Something like:

protocol IssueDescription {
   var description: String {get}

   func isEqual(to: IssueDescription) -> Bool
}

Users would probably implement this via a String enum. Then everyone could define their own, but by using the isEqual hack (which would have to do some casting, which is gross but useful) you'd also be able to tell what specific issue you are having.

Anyway, I'm also not eager to foist a second breaking change on our users so soon after 2.0 (this would have to be 3.0 if we just did it without a transition plan).

from mamba.

jaybpierce avatar jaybpierce commented on May 27, 2024

"Anyway, I'm also not eager to foist a second breaking change on our users so soon after 2.0 (this would have to be 3.0 if we just did it without a transition plan)."

totally agree with that, just wanted to bring it up since I ran across the comment

from mamba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.