Comments (2)
I'm not sure.
We have two opposing concerns.
(1) We'd like all users to be able to create custom ValidationIssue
s for their custom HLS tags. So, having a string is useful for that.
(2) We'd like to be able to id specific validation issues in code. An enum is best for that.
I wonder if we'd be better off with a IssueDescription
protocol instead? Something like:
protocol IssueDescription {
var description: String {get}
func isEqual(to: IssueDescription) -> Bool
}
Users would probably implement this via a String
enum. Then everyone could define their own, but by using the isEqual
hack (which would have to do some casting, which is gross but useful) you'd also be able to tell what specific issue you are having.
Anyway, I'm also not eager to foist a second breaking change on our users so soon after 2.0 (this would have to be 3.0 if we just did it without a transition plan).
from mamba.
"Anyway, I'm also not eager to foist a second breaking change on our users so soon after 2.0 (this would have to be 3.0 if we just did it without a transition plan)."
totally agree with that, just wanted to bring it up since I ran across the comment
from mamba.
Related Issues (20)
- Enable module stability. Now can't use with Swift 5.3.2. HOT 5
- Swift Compiler Code Optimization
- Add Swift Package Manager Support HOT 1
- Tag new release 1.5.6 HOT 6
- Remove `HLS` prefix from all classes HOT 1
- Should be an interface to figure out the muxed/demuxed makeup of an asset HOT 1
- The `playlistType` for a variant playlist should be cached and not calculated every time. HOT 1
- Add a simple function to return segment based info from info about a tag to look for. HOT 1
- Remove the HLSTagCriteria and HLSTagCriterion Query Language objects HOT 1
- v 1.2.0 cocoapods HOT 12
- Add more owners to podspec
- Carthage Build Error HOT 9
- Revert deployment changes made in #61 HOT 2
- Using .transform and replacing a tag of tagDescription PantosTag.Location results in a invalid playlist with literal #Location HOT 3
- How could I add it in my project ? HOT 1
- LHLS Support - Low-Latency HLS HOT 1
- Swift Package Manager support? HOT 1
- Parsing malformed HLS causes crash
- Updating podspec to include fix for static libraries HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mamba.