Comments (5)
I've had a look at implementing this as a custom Python node and ran into issues with allowing any types on inputs that forward the actual type to the corresponding output type.
This makes it impossible to implement this functionality as an extension in a way that is usable in different contexts. (This is one of the reasons ImpactPack has fixed type inputs.)
Looking at the code, the RerouteNode class in the JavaScript is a special node type with graph/type checking. It is doing the forwarding in the code. The RerouteNNode classes could be implemented by either generalizing the RerouteNode class, or as a class that contains N RerouteNode instances.
from comfyui.
Yes that would definitely need to be implemented in JavaScript rather than Python for the current codebase.
It would potentially make more sense as an extension than in the core - but could you explain why you want this / what benefit it would bring to workflow usage?
from comfyui.
The things in the use cases I listed above are things I'm considering on grouping.
I've been organizing the through data in workflows into data buses that move through the workflow. For example:
I'm looking at better ways of grouping these together. -- I'm not keen on the ImpactPack solution of a single pipe as you cannot easily add to the pipe or pull specific data off the pipe.
As a workaround I'm creating data-specific custom bus nodes for my workflow. For example:
Note: one potential issue is that the RerouteNode has an explicit check for the "Reroute" node when checking the connections, so it would be tricky implementing a generic solution as a plugin.
from comfyui.
For reference, I've created https://github.com/rhdunn/comfyui-bus-plugin which has a collection of these different node types that I'm finding useful in my own workflows. One advantage I've noticed with this approach is the ability to use the nodes as a grouped set of primitive nodes -- i.e. as an input group.
from comfyui.
Take a look at hits
https://github.com/Trung0246/ComfyUI-0246
from comfyui.
Related Issues (20)
- comfyUI can conrtol+A all select nodes, and the author can add the function of reversal, which will be used in some aspects HOT 1
- Scrollable Main Menu
- AttributeError: 'ModelPatcher' object has no attribute 'current_device' HOT 1
- Flux Lora from SimpleTuner training not working with ComfyUI HOT 8
- Flux.1 Dev, memory issue HOT 65
- Optional method to visualize and replay the denoising process step by step
- Flux image2image works bad in comfy bc of their noise schedule implementation. HOT 1
- AttributeError: 'ModelPatcher' object has no attribute 'current_device' HOT 2
- What's the relationship between ComfyUI_frontend and ComfyUI HOT 1
- embedding not work HOT 2
- CheckpointSave node is broken after the last update HOT 2
- Flux LoRA getting loaded only partially on a low VRAM GPU after commit 08f92d55e934c19f753b47ec4c51760c68bbe2b7
- After installing the ultralytics library, GPU usage decreased by half and Ksample time doubled HOT 4
- Impossible to download old version of ComfyUI HOT 6
- When I update to ComfyUI: 2504[55ad9d](2024-08-09), sdxl for controlnet is not working HOT 1
- The bug occurs on InstantID with commit:55ad9d5f8c8b906102313e894e471d2f5e833577 HOT 4
- Last update (a3cc3267489bfd44e5a994d98d52481c0cc80730) broke SamplerCustomAdvanced node HOT 8
- Environment variables in paths are not expanded
- Out of index error within the model_patcher.py HOT 1
- list index out of range HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comfyui.